Re: [PATCH] arm64: dts: rockchip: add radxa camera 4k on rock 4d

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] rk3576: build failure due to missing base DT nodes in cam4k overlay
- [Low] rk3576: naming inconsistency between cam4k overlay and combined DTB target
--

commit 50b2333d6c79fd8c588df575daaa658568d99a74
Author: Amin Gattout <amin.gattout@gmail.com>

arm64: dts: rockchip: add radxa camera 4k on rock 4d

Add a device tree overlay for the Radxa Camera 4K (featuring the Sony
IMX415 image sensor) to be applied on the Radxa ROCK 4D camera
connector. The camera connects to CSI HOST1 through the MIPI D-PHY0
in full mode.

> diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile
> index e7936a21c1185..82b2afd420d53 100644
> --- a/arch/arm64/boot/dts/rockchip/Makefile
> +++ b/arch/arm64/boot/dts/rockchip/Makefile
[ ... ]
> @@ -311,6 +312,10 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3576-evb1-v10-pcie1.dtb
>  rk3576-evb1-v10-pcie1-dtbs := rk3576-evb1-v10.dtb \
>  	rk3576-evb1-v10-pcie1.dtbo
>  
> +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3576-rock-4d-radxa-4k-cam.dtb
> +rk3576-rock-4d-radxa-4k-cam-dtbs := rk3576-rock-4d.dtb \
> +	rk3576-rock-4d-radxa-cam4k.dtbo

[Severity: Low]
Could this naming inconsistency cause confusion? The combined DTB target
uses the suffix '4k-cam' while its constituent overlay file uses 'cam4k'.

It deviates from the typical Kbuild naming convention where the combined
target directly reflects its component names.

> +
>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-edgeble-neu6a-wifi.dtb
>  rk3588-edgeble-neu6a-wifi-dtbs := rk3588-edgeble-neu6a-io.dtb \
>  	rk3588-edgeble-neu6a-wifi.dtbo
> diff --git a/arch/arm64/boot/dts/rockchip/rk3576-rock-4d-radxa-cam4k.dtso b/arch/arm64/boot/dts/rockchip/rk3576-rock-4d-radxa-cam4k.dtso
> new file mode 100644
> index 0000000000000..613a3e3515003
> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/rk3576-rock-4d-radxa-cam4k.dtso
[ ... ]
> +&csi1 {
> +	status = "okay";
> +};
> +
> +&csi1_in {
> +	csi1_input: endpoint {
> +		bus-type = <MEDIA_BUS_TYPE_CSI2_DPHY>;
> +		data-lanes = <1 2 3 4>;
> +		link-frequencies = /bits/ 64 <445500000>;
> +		remote-endpoint = <&imx415_output>;
> +	};
> +};
> +
> +&csi_dphy0 {
> +	status = "okay";
> +};
> +
> +&vicap {
> +	status = "okay";
> +};
> +
> +&vicap_mmu {
> +	status = "okay";
> +};

[Severity: Low]
Will this compile correctly during `make dtbs`? 

Since the rk3576 SoC camera subsystem has not been upstreamed yet, it seems
fdtoverlay might fail to resolve these base node labels (&csi1, &csi1_in,
&csi_dphy0, &vicap, &vicap_mmu) against the base rk3576-rock-4d.dtb.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260925-rock4d-cam4k-v1-1-c9519c794fb3@gmail.com?part=1