Re: [PATCH v6 09/12] scsi: ufs: Add NXP S32N79 UFS host controller driver

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] pm: incorrect conditional wrapper used for system sleep callbacks
--

commit d098a24e93df9f55eb797a42c24f7333f79c7078
Author: Larisa Grigore <larisa.grigore@oss.nxp.com>

scsi: ufs: Add NXP S32N79 UFS host controller driver
    
Add support for the UFS host controller on the NXP S32N79 SoC, built on
the Synopsys DesignWare (DWC) UFS architecture, using the UFSHCD DWC and
UFSHCD platform glue. This controller requires S32N79-specific initialization
prior to UIC_LINKSTARTUP.

> diff --git a/drivers/ufs/host/ufs-nxp-s32n7.c b/drivers/ufs/host/ufs-nxp-s32n7.c
> new file mode 100644
> index 0000000000000..f7a017a6d9ae6
> --- /dev/null
> +++ b/drivers/ufs/host/ufs-nxp-s32n7.c

[ ... ]

> +static const struct dev_pm_ops ufs_s32n7_pm_ops = {
> +	SYSTEM_SLEEP_PM_OPS(ufshcd_system_suspend, ufshcd_system_resume)
> +	RUNTIME_PM_OPS(ufshcd_runtime_suspend, ufshcd_runtime_resume, NULL)
> +	.prepare	= pm_ptr(ufshcd_suspend_prepare),
> +	.complete	= pm_ptr(ufshcd_resume_complete),

[Severity: Low]
Is it correct to use pm_ptr() for the .prepare and .complete system sleep
callbacks in ufs_s32n7_pm_ops?

The pm_ptr() macro evaluates to NULL when CONFIG_PM is disabled, but .prepare
and .complete are system sleep callbacks which should evaluate to NULL when
CONFIG_PM_SLEEP is disabled. Wrapping them in pm_ptr() could cause dead code
or build errors if the kernel is configured with CONFIG_PM=y but
CONFIG_PM_SLEEP=n. Should pm_sleep_ptr() be used here instead?

> +};
> +
> +static struct platform_driver ufs_s32n7_driver = {

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260925143534.3298540-1-larisa.grigore@oss.nxp.com?part=9