Re: [PATCH] dt-bindings: power: Convert mediatek,mt2701-scpsys to DT schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: missing if-then conditionals for clock constraints per compatible
--

commit 58363c1987ec9c749cc55c9a540860ff57ed2f23
Author: Rob Herring (Arm) <robh@kernel.org>

    dt-bindings: power: Convert mediatek,mt2701-scpsys to DT schema
    
    Convert the mediatek,mt2701-scpsys binding to DT schema. The mt6735 and
    mt6765 don't exist anywhere. The mt8183 is covered by
    mediatek,mt8195-scpsys.yaml schema. With those dropped, the clock-names
    are trimmed to drop mm-*, isp-*, cam-*, and venc_lt. The venc_lt and
    mfg_2d supplies are dropped as well.

> diff --git a/Documentation/devicetree/bindings/power/mediatek,mt2701-scpsys.yaml b/Documentation/devicetree/bindings/power/mediatek,mt2701-scpsys.yaml
> new file mode 100644
> index 0000000000000..d991b8a008eba
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/mediatek,mt2701-scpsys.yaml

[ ... ]

> +  clocks:
> +    minItems: 1
> +    maxItems: 20
> +
> +  clock-names:
> +    minItems: 1
> +    maxItems: 6
> +    items:
> +      enum:
> +        - mm
> +        - mfg
> +        - ethif
> +        - venc
> +        - jpgdec
> +        - audio
> +        - vdec
> +        - hif_sel

[Severity: Medium]
Does this generic definition omit the hardware-specific constraints from the
original text binding?

The original text binding required specific clock combinations based on the SoC
(for example, MT2712 explicitly required "mm", "mfg", "venc", "jpgdec",
"audio", and "vdec").

This new schema generically allows any device tree to provide 1 to 6 clocks
from the enum in any order, which would allow invalid configurations missing
required clocks to silently pass `dt_binding_check` validation.

Should there be `allOf` and `if-then` conditional blocks to enforce the correct
clocks and clock-names constraints per compatible string?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260925155927.1707560-1-robh@kernel.org?part=1