Re: [PATCH] arm64: dts: qcom: x1e80100-dell-xps13-9345: add the front camera

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dts: leftover panic-indicator property in privacy_led node
--

commit 36298c1fea529d8d4721b3106200dbc232c81349
Author: Liviu Nicoara <lnicoara@thinkoid.org>

arm64: dts: qcom: x1e80100-dell-xps13-9345: add the front camera

This commit describes the OV02C10 front camera and its wiring for the Dell
XPS 13 9345. It configures the CCI1 bus, CSIPHY4, and assigns the white
camera indicator LED to serve as the sensor's privacy LED.

> diff --git a/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts b/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts
> index ad62350ba6701..73f06fdcd1381 100644
> --- a/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts
> +++ b/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts
[ ... ]
> @@ -46,14 +48,13 @@ leds {
>  		pinctrl-names = "default";
>  		pinctrl-0 = <&cam_indicator_en>;
>  
> -		led-camera-indicator {
> +		privacy_led: led-camera-indicator {
>  			label = "white:camera-indicator";
>  			function = LED_FUNCTION_INDICATOR;
>  			color = <LED_COLOR_ID_WHITE>;
>  			gpios = <&tlmm 110 GPIO_ACTIVE_HIGH>;
>  			linux,default-trigger = "none";
>  			default-state = "off";
> -			/* Reuse as a panic indicator until we get a "camera on" trigger */
>  			panic-indicator;

[Severity: Low]
The commit message and the removed comment indicate this LED was only used as
a panic indicator temporarily until a "camera on" trigger was available.
However, while the comment is removed, the panic-indicator property remains.
Should this property also be removed from the privacy_led node?

>  		};
>  	};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260925181024.20352-1-lnicoara@thinkoid.org?part=1