From: sashiko-bot@kernel.org
To: "Muhammad Abu Bakar" <m.abubakar365@yahoo.com>
Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: iio: pressure: add Sensirion SDP31
Date: Sat, 26 Sep 2026 15:46:39 +0000 [thread overview]
Message-ID: <20260926154639.A4C2B1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260926154118.5471-2-m.abubakar365@yahoo.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: missing interrupts property for IRQ pin
--
commit 4db91d50e49cd1f9c9265de070c68dad6d777537
Author: Muhammad Abu Bakar <m.abubakar365@yahoo.com>
dt-bindings: iio: pressure: add Sensirion SDP31
This commit adds device tree bindings for the Sensirion SDP31 differential
pressure sensor. The sensor is an I2C device that reports both pressure and
temperature.
> diff --git a/Documentation/devicetree/bindings/iio/pressure/sensirion,sdp31.yaml b/Documentation/devicetree/bindings/iio/pressure/sensirion,sdp31.yaml
> new file mode 100644
> index 0000000000000..a98e7c97ef160
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/pressure/sensirion,sdp31.yaml
[ ... ]
> +required:
> + - compatible
> + - reg
> + - vdd-supply
> +
> +additionalProperties: false
[Severity: Medium]
Does this schema fully describe the hardware capabilities?
The Sensirion SDP31 has an IRQ/ADDR pin (Pin 4) that a board designer might
wire to an interrupt controller. Because additionalProperties is set to false
here, if a device tree includes the interrupts property to describe this
hardware connection, the schema validation will fail.
Device tree bindings typically describe the full capabilities of the hardware,
rather than just what the current OS driver supports. Should the interrupts
property be explicitly defined in this schema to prevent validation errors for
complete hardware descriptions?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260926154118.5471-1-m.abubakar365@yahoo.com?part=1
next prev parent reply other threads:[~2026-09-26 15:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260926154118.5471-1-m.abubakar365.ref@yahoo.com>
2026-09-26 15:41 ` [PATCH v3 0/2] iio: pressure: add Sensirion SDP31 driver Muhammad Abu Bakar
2026-09-26 15:41 ` [PATCH v3 1/2] dt-bindings: iio: pressure: add Sensirion SDP31 Muhammad Abu Bakar
2026-09-26 15:46 ` sashiko-bot [this message]
2026-09-27 17:24 ` Jonathan Cameron
2026-09-26 15:41 ` [PATCH v3 2/2] iio: pressure: add Sensirion SDP31 driver Muhammad Abu Bakar
2026-09-27 17:35 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260926154639.A4C2B1F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=m.abubakar365@yahoo.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox