Re: [PATCH net-next v23 8/9] net: dsa: mt7530: generalize and move common function to lib module

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] net/dsa: mt7530: lost multicast counter in rtnl_link_stats64
--

commit 7c73e5182e23c339dc9a92fe7e7c4d4b45721dd7
Author: Christian Marangi <ansuelsmth@gmail.com>

net: dsa: mt7530: generalize and move common function to lib module

This commit introduces a library module for MT7530 switches, moving common
functions there to prepare for Airoha switch support. The migrated functions
are generalized using the reg_field regmap API.

> diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c
> --- a/drivers/net/dsa/mt7530.c
> +++ b/drivers/net/dsa/mt7530.c
[ ... ]
> @@ -861,38 +833,40 @@ static void mt7530_read_port_stats64(struct mt7530_priv *priv, int port,
>  	 * To simulate a global frame counter, read Unicast and addition Multicast
>  	 * and Broadcast later
>  	 */
> -	mt7530_read_port_stats(priv, port, MT7530_PORT_MIB_RX_UNICAST, 1,
> -			       &storage->rx_packets);
> -	mt7530_read_port_stats(priv, port, MT7530_PORT_MIB_RX_MULTICAST, 1,
> -			       &storage->multicast);
> -	storage->rx_packets += storage->multicast;
> -	mt7530_read_port_stats(priv, port, MT7530_PORT_MIB_RX_BROADCAST, 1,
> -			       &data);
> +	mt7530_lib_read_port_stats(lib_priv->fields[MT7530_MIB_RX_UNICAST],
> +				   NULL, port, &storage->rx_packets);
> +	mt7530_lib_read_port_stats(lib_priv->fields[MT7530_MIB_RX_MULTICAST],
> +				   NULL, port, &data);
> +	storage->rx_packets += data;

[Severity: Medium]
Does this refactoring inadvertently drop the assignment to storage->multicast?

The hardware multicast counter is correctly read into the local data variable
and added to rx_packets, but it is no longer being assigned to
storage->multicast as it was in the original code. This will cause the
multicast statistics metric (exported via rtnl_link_stats64) to permanently
report 0.

> +	mt7530_lib_read_port_stats(lib_priv->fields[MT7530_MIB_RX_BROADCAST],
> +				   NULL, port, &data);
>  	storage->rx_packets += data;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260925182435.21207-1-ansuelsmth@gmail.com?part=8