Re: [PATCH v2 3/3] arm64: dts: qcom: sc8280xp-x13s: Add embedded controller

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: forbidden input-enable in TLMM pinctrl
--

commit 3b04b58deccd1a5510d626dacae4e53b304e7984
Author: Clover <alex@ironrobin.net>

arm64: dts: qcom: sc8280xp-x13s: Add embedded controller

This commit enables the embedded controller at address 0x28 on i2c8 with
GPIO103 as its falling-edge event interrupt. It also configures the QUP8 bus,
the GPIO103 input, and the GPIO176 active-high power-state output.

> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> index 218573a97785b..1b875809773da 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts

[ ... ]

> @@ -1571,6 +1590,21 @@ sc-rgb-xshut-n-pins {
>  		};
>  	};
>  
> +	ec_int_n: ec-int-n-state {
> +		pins = "gpio103";
> +		function = "gpio";
> +		input-enable;

[Severity: Low]
Does this property cause a dt-binding schema validation error?

The qcom,tlmm-common.yaml schema explicitly forbids the input-enable property
in the TLMM pinctrl bindings. While PMIC pinctrls allow this property, the
TLMM (Top Level Mode Multiplexer) pinctrl bindings prohibit it, and running
make dtbs_check will fail with a DT binding validation error.

The driver consuming the GPIO establishes the input direction (e.g., via
gpiod_direction_input()) rather than relying on the pinctrl configuration.

> +		/* Preserve firmware pull configuration; no bias override. */
> +	};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260926195415.5995-1-alex@ironrobin.net?part=3