Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Alim Akhtar" <alim.akhtar@samsung.com>
Cc: linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org,
	robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: watchdog: Add Exynos8855 watchdog compatible string
Date: Sun, 27 Sep 2026 14:20:52 +0000	[thread overview]
Message-ID: <20260927142052.E02FD1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260927143100.3576195-1-alim.akhtar@samsung.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: watchdog: missing comma in samsung,syscon-phandle description
--

commit 8354ecfd36bd009fe5b5d0f2ef81e3977d3ba5fd
Author: Alim Akhtar <alim.akhtar@samsung.com>

dt-bindings: watchdog: Add Exynos8855 watchdog compatible string

This commit adds the samsung,exynos8855-wdt compatible string to the
watchdog device tree binding documentation. It updates the property
descriptions and constraint blocks to indicate that the Exynos8855 requires
the cluster-index and syscon-phandle properties.

> diff --git a/Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml b/Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml
> index a32c478315779..517c0e1cd78bf 100644
> --- a/Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml
[ ... ]
> @@ -52,13 +53,13 @@ properties:
>      enum: [0, 1, 2]
>      description:
>        Index of CPU cluster on which watchdog is running (in case of Exynos850,
> -      Exynos990 or Google gs101).
> +      Exynos8855, Exynos990 or Google gs101).
>  
>    samsung,syscon-phandle:
>      $ref: /schemas/types.yaml#/definitions/phandle
>      description:
>        Phandle to the PMU system controller node (in case of Exynos5250,
> -      Exynos5420, Exynos5515, Exynos7, Exynos850, Exynos990 and gs101).
> +      Exynos5420, Exynos5515, Exynos7, Exynos850, Exynos8855 Exynos990 and gs101).

[Severity: Low]
This isn't a functional issue, but is there a missing comma between
Exynos8855 and Exynos990 in this updated description string?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260927143100.3576195-1-alim.akhtar@samsung.com?part=1

  reply	other threads:[~2026-09-27 14:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20260927141253epcas5p371d497edc6756f13ce2215af4f380fb4@epcas5p3.samsung.com>
2026-09-27 14:30 ` [PATCH 1/2] dt-bindings: watchdog: Add Exynos8855 watchdog compatible string Alim Akhtar
2026-09-27 14:20   ` sashiko-bot [this message]
2026-09-27 14:31   ` [PATCH 2/2] watchdog: s3c2410_wdt: Add support for Exynos8855 SoC Alim Akhtar
2026-09-27 14:21     ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260927142052.E02FD1F000FF@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=alim.akhtar@samsung.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox