From: Alim Akhtar <alim.akhtar@samsung.com>
To: krzk@kernel.org, peter.griffin@linaro.org, robh@kernel.org,
conor+dt@kernel.org, linusw@kernel.org
Cc: linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-watchdog@vger.kernel.org,
linux@roeck-us.net, hajun.sung@samsung.com,
wim@linux-watchdog.org, Alim Akhtar <alim.akhtar@samsung.com>
Subject: [PATCH v2 2/2] watchdog: s3c2410_wdt: Add support for Exynos8855 SoC
Date: Sun, 27 Sep 2026 20:57:38 +0530 [thread overview]
Message-ID: <20260927152738.3673504-2-alim.akhtar@samsung.com> (raw)
In-Reply-To: <20260927152738.3673504-1-alim.akhtar@samsung.com>
Watchdog IP on this SoC is similar to Exynos850/ExynosAutov{9/920}.
This does not have CNT_EN_WDT bit in PMU and offset of RST_STAT is
different then the previously support SoC.
Reuse the offset as much as from already supported SoC
Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
---
*Changes in V2:
- Fixed Sashiko review comments
- [Low] watchdog: confusing reuse of CLUSTER0 macro for CLUSTER1
- [Low] watchdog: space-based alignment for EXYNOS8855_RST_STAT_REG_OFFSET
drivers/watchdog/s3c2410_wdt.c | 27 +++++++++++++++++++++++++++
1 file changed, 27 insertions(+)
diff --git a/drivers/watchdog/s3c2410_wdt.c b/drivers/watchdog/s3c2410_wdt.c
index 7053963fb0ac..007c05ed2c7b 100644
--- a/drivers/watchdog/s3c2410_wdt.c
+++ b/drivers/watchdog/s3c2410_wdt.c
@@ -58,6 +58,7 @@
#define S3C2410_WATCHDOG_DEFAULT_TIME (15)
#define EXYNOS5_RST_STAT_REG_OFFSET 0x0404
+#define EXYNOS8855_RST_STAT_REG_OFFSET 0x10
#define EXYNOS5_WDT_DISABLE_REG_OFFSET 0x0408
#define EXYNOS5_WDT_MASK_RESET_REG_OFFSET 0x040c
#define EXYNOS850_CLUSTER0_NONCPU_OUT 0x1220
@@ -73,6 +74,7 @@
#define EXYNOS850_CLUSTER0_WDTRESET_BIT 24
#define EXYNOS850_CLUSTER1_WDTRESET_BIT 23
+#define EXYNOS8855_CLUSTER1_WDTRESET_BIT 25
#define EXYNOSAUTOV9_CLUSTER0_WDTRESET_BIT 25
#define EXYNOSAUTOV9_CLUSTER1_WDTRESET_BIT 24
#define EXYNOSAUTOV920_CLUSTER0_WDTRESET_BIT 0
@@ -281,6 +283,26 @@ static const struct s3c2410_wdt_variant drv_data_exynos850_cl1 = {
QUIRK_HAS_PMU_RST_STAT | QUIRK_HAS_PMU_CNT_EN,
};
+static const struct s3c2410_wdt_variant drv_data_exynos8855_cl0 = {
+ .mask_reset_reg = EXYNOS850_CLUSTER0_NONCPU_INT_EN,
+ .mask_bit = 2,
+ .mask_reset_inv = true,
+ .rst_stat_reg = EXYNOS8855_RST_STAT_REG_OFFSET,
+ .rst_stat_bit = EXYNOS850_CLUSTER0_WDTRESET_BIT,
+ .quirks = QUIRK_HAS_WTCLRINT_REG | QUIRK_HAS_PMU_MASK_RESET |
+ QUIRK_HAS_PMU_RST_STAT | QUIRK_HAS_DBGACK_BIT,
+};
+
+static const struct s3c2410_wdt_variant drv_data_exynos8855_cl1 = {
+ .mask_reset_reg = EXYNOSAUTOV920_CLUSTER1_NONCPU_INT_EN,
+ .mask_bit = 2,
+ .mask_reset_inv = true,
+ .rst_stat_reg = EXYNOS8855_RST_STAT_REG_OFFSET,
+ .rst_stat_bit = EXYNOS8855_CLUSTER1_WDTRESET_BIT,
+ .quirks = QUIRK_HAS_WTCLRINT_REG | QUIRK_HAS_PMU_MASK_RESET |
+ QUIRK_HAS_PMU_RST_STAT | QUIRK_HAS_DBGACK_BIT,
+};
+
static const struct s3c2410_wdt_variant drv_data_exynos990_cl0 = {
.mask_reset_reg = GS_CLUSTER0_NONCPU_INT_EN,
.mask_bit = 2,
@@ -400,6 +422,8 @@ static const struct of_device_id s3c2410_wdt_match[] = {
.data = &drv_data_exynos7 },
{ .compatible = "samsung,exynos850-wdt",
.data = &drv_data_exynos850_cl0 },
+ { .compatible = "samsung,exynos8855-wdt",
+ .data = &drv_data_exynos8855_cl0 },
{ .compatible = "samsung,exynos990-wdt",
.data = &drv_data_exynos990_cl0 },
{ .compatible = "samsung,exynosautov9-wdt",
@@ -723,6 +747,7 @@ s3c2410_get_wdt_drv_data(struct platform_device *pdev, struct s3c2410_wdt *wdt)
/* Choose Exynos850/ExynosAutov9 driver data w.r.t. cluster index */
if (variant == &drv_data_exynos850_cl0 ||
variant == &drv_data_exynosautov9_cl0 ||
+ variant == &drv_data_exynos8855_cl0 ||
variant == &drv_data_gs101_cl0 ||
variant == &drv_data_exynosautov920_cl0 ||
variant == &drv_data_exynos990_cl0) {
@@ -740,6 +765,8 @@ s3c2410_get_wdt_drv_data(struct platform_device *pdev, struct s3c2410_wdt *wdt)
case 1:
if (variant == &drv_data_exynos850_cl0)
variant = &drv_data_exynos850_cl1;
+ else if (variant == &drv_data_exynos8855_cl0)
+ variant = &drv_data_exynos8855_cl1;
else if (variant == &drv_data_exynosautov9_cl0)
variant = &drv_data_exynosautov9_cl1;
else if (variant == &drv_data_gs101_cl0)
--
2.34.1
next prev parent reply other threads:[~2026-09-27 15:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20260927150938epcas5p33b7d0495f8d9a8e84bf5f09c66e757fb@epcas5p3.samsung.com>
2026-09-27 15:27 ` [PATCH v2 1/2] dt-bindings: watchdog: Add Exynos8855 watchdog compatible string Alim Akhtar
2026-09-27 15:27 ` Alim Akhtar [this message]
2026-10-02 15:01 ` [PATCH v2 2/2] watchdog: s3c2410_wdt: Add support for Exynos8855 SoC Peter Griffin
2026-10-06 4:28 ` Alim Akhtar
2026-09-27 17:11 ` [PATCH v2 1/2] dt-bindings: watchdog: Add Exynos8855 watchdog compatible string Krzysztof Kozlowski
2026-09-30 3:25 ` Alim Akhtar
2026-10-02 11:24 ` Peter Griffin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260927152738.3673504-2-alim.akhtar@samsung.com \
--to=alim.akhtar@samsung.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hajun.sung@samsung.com \
--cc=krzk@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=peter.griffin@linaro.org \
--cc=robh@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox