From: sashiko-bot@kernel.org
To: "Svyatoslav Ryhel" <clamor95@gmail.com>
Cc: conor+dt@kernel.org, robh@kernel.org, devicetree@vger.kernel.org,
lee@kernel.org, mfd@lists.linux.dev
Subject: Re: [PATCH v1 1/3] regulator: dt-bindings: maxim,max8907: Convert to DT schema
Date: Sun, 27 Sep 2026 16:05:39 +0000 [thread overview]
Message-ID: <20260927160539.E95F11F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260927155745.187758-2-clamor95@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: broken schema reference to tegra-regulators-coupling.yaml
--
commit 5ef18cb507e67969206ad4c580a12c88380df6ac
Author: Svyatoslav Ryhel <clamor95@gmail.com>
regulator: dt-bindings: maxim,max8907: Convert to DT schema
Convert Maxim MAX8907 regulator binding from text to DT schema. Reference
to nvidia,tegra-regulators-coupling in child regulator nodes.
> diff --git a/Documentation/devicetree/bindings/regulator/maxim,max8907.yaml b/Documentation/devicetree/bindings/regulator/maxim,max8907.yaml
> new file mode 100644
> index 0000000000000..e4e1390a49b9b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/maxim,max8907.yaml
> @@ -0,0 +1,285 @@
[ ... ]
> + regulators:
> + type: object
> + additionalProperties: false
> +
> + patternProperties:
> + "^(sd[1-3]|ldo([1-9]|1[0-9]|20)|bbat|mbatt|out(5v|33v)|sdby|vrtc)$":
> + allOf:
> + - $ref: /schemas/regulator/regulator.yaml#
> + - $ref: /schemas/regulator/nvidia,tegra-regulators-coupling.yaml#
[Severity: Medium]
Will this reference break the dt_binding_check build target?
The tegra-regulators-coupling binding has not been converted to YAML yet
(it only exists as nvidia,tegra-regulators-coupling.txt in this tree).
Because of this, the dt-schema tool will throw a RefResolutionError when
it attempts to resolve the missing file, which breaks schema validation
for the bindings subsystem.
> + unevaluatedProperties: false
> +
> +patternProperties:
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260927155745.187758-1-clamor95@gmail.com?part=1
next prev parent reply other threads:[~2026-09-27 16:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-27 15:57 [PATCH v1 0/3] mfd: max8907: Schema, pdata and poweroff Svyatoslav Ryhel
2026-09-27 15:57 ` [PATCH v1 1/3] regulator: dt-bindings: maxim,max8907: Convert to DT schema Svyatoslav Ryhel
2026-09-27 16:05 ` sashiko-bot [this message]
2026-09-28 12:58 ` Rob Herring (Arm)
2026-09-27 15:57 ` [PATCH v1 2/3] mfd: max8907: Remove platform_data based probing Svyatoslav Ryhel
2026-09-27 16:06 ` sashiko-bot
2026-09-27 15:57 ` [PATCH v1 3/3] mfd: max8907: Convert to use device managed poweroff handler Svyatoslav Ryhel
2026-09-27 16:07 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260927160539.E95F11F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=clamor95@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lee@kernel.org \
--cc=mfd@lists.linux.dev \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox