From: Krzysztof Kozlowski <krzk@kernel.org>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Cc: Jingyi Wang <jingyi.wang@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Abel Vesa <abelvesa@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
aiqun.yu@oss.qualcomm.com, tingwei.zhang@oss.qualcomm.com,
trilok.soni@oss.qualcomm.com, yijie.yang@oss.qualcomm.com,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: arm: qcom,ids: Add SoC ID for SM8950
Date: Mon, 28 Sep 2026 12:11:56 +0200 [thread overview]
Message-ID: <20260928-laughing-malachite-spoonbill-5c1bc8@quoll> (raw)
In-Reply-To: <8157618a-7b8b-4c2e-871b-5bd3f5ec17c3@oss.qualcomm.com>
On Thu, Sep 24, 2026 at 09:28:20AM +0200, Konrad Dybcio wrote:
> On 9/23/26 9:06 AM, Krzysztof Kozlowski wrote:
> > On 23/09/2026 01:06, Jingyi Wang wrote:
> >> Add the ID for the Qualcomm SM8950 SoC which represents the Maili
> >> platform.
> >>
> >> Signed-off-by: Jingyi Wang <jingyi.wang@oss.qualcomm.com>
> >> ---
> >> include/dt-bindings/arm/qcom,ids.h | 1 +
> >
> >
> > Standard question: where is DTS? Why is this sent separately from the
> > rest of the patches targeting the same subsystem? Please organize entire
> > work targeting maintainers in relevant patchsets.
>
> I see no reason for the grumpiness here, this is perfectly okay in
> my books
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Still, having it separate from initial DTS for the SoC brings no
benefits. I am not grumpy, having this groupped makes things easier to
review.
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-09-28 10:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-22 23:06 [PATCH 0/2] Add Qualcomm SM8950 socinfo Jingyi Wang
2026-09-22 23:06 ` [PATCH 1/2] dt-bindings: arm: qcom,ids: Add SoC ID for SM8950 Jingyi Wang
2026-09-23 7:06 ` Krzysztof Kozlowski
2026-09-24 7:20 ` Jingyi Wang
2026-09-24 7:28 ` Konrad Dybcio
2026-09-28 10:11 ` Krzysztof Kozlowski [this message]
2026-09-22 23:06 ` [PATCH 2/2] soc: qcom: socinfo: Add SM8950 SoC ID Jingyi Wang
2026-09-29 3:14 ` (subset) [PATCH 0/2] Add Qualcomm SM8950 socinfo Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260928-laughing-malachite-spoonbill-5c1bc8@quoll \
--to=krzk@kernel.org \
--cc=abelvesa@kernel.org \
--cc=aiqun.yu@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jingyi.wang@oss.qualcomm.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=tingwei.zhang@oss.qualcomm.com \
--cc=trilok.soni@oss.qualcomm.com \
--cc=yijie.yang@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox