From: sashiko-bot@kernel.org
To: "Josef Schlehofer" <pepe.schlehofer@gmail.com>
Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org,
lee@kernel.org, linux-leds@vger.kernel.org
Subject: Re: [PATCH v3 2/2] leds: Add support for Turris 1.x LEDs
Date: Mon, 28 Sep 2026 11:34:43 +0000 [thread overview]
Message-ID: <20260928113443.91D381F00893@smtp.kernel.org> (raw)
In-Reply-To: <20260928111907.72592-3-pepe.schlehofer@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] leds: commit message prefix omits driver name
--
commit 70e4f9934d8651d406ba12c71793199adbcac17c
Author: Pali Rohár <pali@kernel.org>
leds: Add support for Turris 1.x LEDs
This commit adds a driver for the eight RGB LEDs on the front panel of the
CZ.NIC Turris 1.x routers. The LEDs use the multicolor LED class and can be
driven by hardware events via a private CPLD trigger.
> leds: Add support for Turris 1.x LEDs
[Severity: Low]
Does this commit message prefix omit the required driver name?
According to the LED subsystem naming conventions, the prefix format should
include the driver name before the capitalized description, for example:
"leds: <Driver>: <Capitalized description>".
Could this be updated to something like "leds: turris-1x: Add support for
Turris 1.x LEDs" to ensure consistent git history categorization?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260928111907.72592-1-pepe.schlehofer@gmail.com?part=2
next prev parent reply other threads:[~2026-09-28 11:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-28 11:19 [PATCH v3 0/2] leds: Add support for CZ.NIC Turris 1.x LEDs Josef Schlehofer
2026-09-28 11:19 ` [PATCH v3 1/2] dt-bindings: leds: Add CZ.NIC Turris 1.x LED controller Josef Schlehofer
2026-09-28 11:23 ` sashiko-bot
2026-10-07 21:06 ` Rob Herring (Arm)
2026-09-28 11:19 ` [PATCH v3 2/2] leds: Add support for Turris 1.x LEDs Josef Schlehofer
2026-09-28 11:34 ` sashiko-bot [this message]
2026-09-28 13:07 ` Andy Shevchenko
2026-09-29 14:45 ` Marek Behún
2026-09-29 15:30 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260928113443.91D381F00893@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pepe.schlehofer@gmail.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox