From: sashiko-bot@kernel.org
To: "Primoz Fiser" <primoz.fiser@norik.com>
Cc: Frank.Li@kernel.org, robh@kernel.org, devicetree@vger.kernel.org,
conor+dt@kernel.org, imx@lists.linux.dev
Subject: Re: [PATCH] ARM: dts: imx6dl-phytec-mira: Add phyBOARD-Mira-i.MX6DL with eMMC
Date: Mon, 28 Sep 2026 12:44:49 +0000 [thread overview]
Message-ID: <20260928124450.3B22D1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260928123612.2250601-1-primoz.fiser@norik.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] arm: dts: build failure due to non-existent .dtsi inclusion
--
commit d27346cce6650da77827531e0a8db928754f5352
Author: Primoz Fiser <primoz.fiser@norik.com>
ARM: dts: imx6dl-phytec-mira: Add phyBOARD-Mira-i.MX6DL with eMMC
Add device-tree for PHYTEC phyBOARD-Mira-i.MX6 DL board with eMMC. The
variant with NAND storage is already present in-tree. Now let's add the
eMMC variant for which the compatible string "imx6dl-pbac06-emmc"
already exists too but was not used until now.
> diff --git a/arch/arm/boot/dts/nxp/imx/imx6dl-phytec-mira-rdk-emmc.dts b/arch/arm/boot/dts/nxp/imx/imx6dl-phytec-mira-rdk-emmc.dts
> new file mode 100644
> index 0000000000000..aa3239660bca7
> --- /dev/null
> +++ b/arch/arm/boot/dts/nxp/imx/imx6dl-phytec-mira-rdk-emmc.dts
> @@ -0,0 +1,75 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Copyright (C) 2018 PHYTEC Messtechnik GmbH
> + * Author: Christian Hemp <c.hemp@phytec.de>
> + */
> +
> +/dts-v1/;
> +#include "imx6dl.dtsi"
> +#include "imx6dl-phytec-phycore-som.dtsi"
[Severity: Low]
Could there be a typo in this include filename? The file
"imx6dl-phytec-phycore-som.dtsi" doesn't exist in the tree, which results in
a fatal error during device tree compilation when the C preprocessor fails
to find it.
Should this include "imx6qdl-phytec-phycore-som.dtsi" instead, which does
exist and is used by similar variants?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260928123612.2250601-1-primoz.fiser@norik.com?part=1
next prev parent reply other threads:[~2026-09-28 12:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-28 12:36 [PATCH] ARM: dts: imx6dl-phytec-mira: Add phyBOARD-Mira-i.MX6DL with eMMC Primoz Fiser
2026-09-28 12:44 ` sashiko-bot [this message]
2026-09-28 12:51 ` Primoz Fiser
2026-10-01 15:06 ` Frank.Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260928124450.3B22D1F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=primoz.fiser@norik.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox