Re: [PATCH v8 01/10] ASoC: dt-bindings: qcom,shikra-qaif-cpu: Add binding

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: omitted header file with QAIF DAI ID constants
--

commit 1e97e3fc9f754770e71857dc90e01e438eeb58ff
Author: Harendra Gautam <harendra.gautam@oss.qualcomm.com>

ASoC: dt-bindings: qcom,shikra-qaif-cpu: Add binding

This commit adds the Devicetree binding for the Qualcomm Audio Interface
(QAIF) CPU DAI controller used on the Shikra audio platform.

> QAIF routes audio between system memory, external PCM/TDM/MI2S serial
> interfaces and the internal Bolero/WCD codec. Platform Devicetree files
> need a binding to describe the controller resources, DAI cells and per-
> interface AIF configuration, and named constants to avoid raw numeric IDs
> in sound-dai references and child-node reg values.

[Severity: Medium]
The commit message mentions adding named constants to avoid raw numeric
IDs, but it appears the corresponding dt-bindings header file was omitted
from this patch. Was this header left out accidentally?

> diff --git a/Documentation/devicetree/bindings/sound/qcom,shikra-qaif-cpu.yaml b/Documentation/devicetree/bindings/sound/qcom,shikra-qaif-cpu.yaml
> new file mode 100644
> index 0000000000000..5cabbe54d6fd8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/qcom,shikra-qaif-cpu.yaml
[ ... ]
> +patternProperties:
> +  '^aif@[0-9a-f]+$':
> +    type: object
> +    description:
> +      QAIF AIF interface child node for PCM, TDM or MI2S configuration.
> +
> +    properties:
> +      reg:
> +        maxItems: 1
> +        description:
> +          DAI ID of the AIF interface (QAIF_MI2S_AIF* or QAIF_TDM_AIF*).

[Severity: Medium]
Since the header file defining QAIF_MI2S_AIF* and QAIF_TDM_AIF* is missing,
device tree authors following this documentation will experience build
failures if they attempt to use these macros. Should the header be added
in this patch series?

[ ... ]
> +examples:
> +  - |
[ ... ]
> +            #sound-dai-cells = <1>;
> +            #address-cells = <1>;
> +            #size-cells = <0>;
> +
> +            aif@b5 {
> +                reg = <181>;

[Severity: Medium]
Because the macros are missing, this example falls back to using a raw
numeric ID (181), which contradicts the commit message's goal of avoiding
raw numeric IDs. Does this need to be updated to use the named constant
once the header is included?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260928-b4-qaif-shikra-audio-v8-0-ac618057fe85@oss.qualcomm.com?part=1