Re: [PATCH 2/3] dt-bindings: crypto: fsl,sec-v4.0: add fsl,qi2-crypto-priority

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: crypto: OS-specific software policy encoded in device tree
--

commit 16c27ce3ed51863cb681908accfda1674f3516d1
Author: Vincent Jardin <vjardin@free.fr>

dt-bindings: crypto: fsl,sec-v4.0: add fsl,qi2-crypto-priority

This commit adds a new property, fsl,qi2-crypto-priority, to the
fsl,sec-v4.0 device tree binding. The property is intended to allow boards
to specify the default in-kernel crypto API priority for the SEC device
relative to CPU implementations.

> diff --git a/Documentation/devicetree/bindings/crypto/fsl,sec-v4.0.yaml b/Documentation/devicetree/bindings/crypto/fsl,sec-v4.0.yaml
> --- a/Documentation/devicetree/bindings/crypto/fsl,sec-v4.0.yaml
> +++ b/Documentation/devicetree/bindings/crypto/fsl,sec-v4.0.yaml
> @@ -86,6 +86,15 @@ properties:
>      description: Defines the 'ERA' of the SEC device.
>      $ref: /schemas/types.yaml#/definitions/uint32
>  
> +  fsl,qi2-crypto-priority:
> +    description:
> +      Crypto API priority of the algorithms the DPAA2 (QI2) front end
> +      registers. Below the CPU's own implementations, the SEC is used only
> +      when asked for by driver name. The dpaa2_caam.priority module
> +      parameter overrides it.

[Severity: Medium]
Does this property encode an OS-specific software policy directly into the 
device tree?

The device tree is intended to describe hardware topology rather than Linux 
internal software routing policies like Crypto API priority or module 
parameters. Because device tree properties become long-term ABI, exposing 
Linux-specific module parameter equivalents via DT pollutes the OS-agnostic 
design.

Would it be better to handle this fallback algorithm ordering exclusively 
within the driver or module configuration?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260928-for-upstream-caam-qi2-priority-v1-0-e4a8e5f01dbc@free.fr?part=2