Re: [PATCH v3 2/5] arm64: dts: qcom: eliza-cqs-evk: Move sound card support to Eliza EVK generic

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] sound: hardcoded cqs model string in generic eliza-evk.dtsi
--

commit 59abb23a6bd8ac9951db58edd7aaebd3f7f631c7
Author: Abel Vesa <abel.vesa@oss.qualcomm.com>

arm64: dts: qcom: eliza-cqs-evk: Move sound card support to Eliza EVK generic

This patch moves the sound related device tree nodes from the Eliza CQS EVK
specific file to the generic Eliza EVK implementation. The stated goal is
to allow reuse across all variants, including the upcoming CQM EVK.

> diff --git a/arch/arm64/boot/dts/qcom/eliza-evk.dtsi b/arch/arm64/boot/dts/qcom/eliza-evk.dtsi
> index 6c5cc47a183ea..726fd8dd6c0d0 100644
> --- a/arch/arm64/boot/dts/qcom/eliza-evk.dtsi
> +++ b/arch/arm64/boot/dts/qcom/eliza-evk.dtsi

[ ... ]

> @@ -63,6 +65,55 @@ pmic_glink_ss_in: endpoint {
>  		};
>  	};
>  
> +	sound {
> +		compatible = "qcom,eliza-sndcard", "qcom,sm8450-sndcard";
> +		model = "eliza-cqs-evk";

[Severity: Low]
Since the eliza-evk.dtsi file is meant to be generically shared with other
variants like the Eliza CQM EVK, will hardcoding the model string to
"eliza-cqs-evk" in the shared sound node cause those other variants to
incorrectly advertise their ALSA sound card as the CQS EVK to userspace?

Could this model property be defined or overridden in the variant-specific
device tree files instead of the generic include?

> +
> +		audio-routing = "SpkrLeft IN", "WSA_SPK1 OUT",
> +				"SpkrRight IN", "WSA_SPK2 OUT",
> +				"VA DMIC0", "vdd-micb",

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260928-dts-qcom-eliza-add-ufs-variant-v3-0-9a2fdbf6baf2@oss.qualcomm.com?part=2