Re: [PATCH 1/2] dt-bindings: iio: pressure: add Sensirion SDP31

[Muhammad Abu Bakar <m.abubakar365@yahoo.com>]

On Sun, 20 Sep 2026 01:40:32 +0100
Jonathan Cameron <jic23@kernel.org> wrote:

Hi Jonathan,

Apologies - your v1 review replies were going to my spam folder and I
only saw them now. I have fixed that. I agree with all of the feedback
and will address it in v4.

> > +  compatible:
> > +    const: sensirion,sdp31
>
> It looks like there several similar parts that only differ in
> range.  Would be nice to support them all out of the box.  Fine
> to just test on one in a family like this.

The SDP31/SDP32/SDP33 differ only in measurement range, and the driver
already reads the scale factor from the sensor at runtime, so I will add
compatibles for all three (tested on the SDP31).

> > +  vdd-supply: true
>
> Where is the irq?  Even if a driver doesn't yet support all the
> features, the dt binding should describe them if at all possible.

I will add an optional interrupts property in v4.

> > +required:
> > +  - compatible
> > +  - reg
>
> Sashiko correctly points out that devices tend to need vdd-supply to
> work.  Hence it should be in the required.

Agreed - vdd-supply has been in the required list since v2.

I will also address your v3 driver comments (shorter I2C reads for the
normal measurement, and reading the scale factor separately) in v4.

Thanks for your patience, and for flagging the missed replies.

Muhammad Abu Bakar