Re: [PATCH v14 2/2] arm: dts: aspeed: ventura: add Meta Ventura BMC

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] dts: max31790 undocumented child nodes and properties
- [Low] dts: aspeed-i2c undocumented i2c-scl-clk-low-timeout-us property
--

commit 36f26891634e24be887571e8b0992390654a929b
Author: Sue Wang <suwangquanta@gmail.com>

arm: dts: aspeed: ventura: add Meta Ventura BMC

This commit adds the Linux device tree for Meta (Facebook) Ventura specific
devices connected to the BMC (AST2600) SoC. It configures the hardware needed
to detect liquid leakage, log events, and take necessary actions.

> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura.dts
> new file mode 100644
> index 0000000000000..62a60741bccb3
> --- /dev/null
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura.dts

[ ... ]

> +		i2c3mux0ch5: i2c@5 {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			reg = <5>;
> +
> +			pwm@20 {
> +				compatible = "maxim,max31790";
> +				reg = <0x20>;
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +				channel@2 {
> +					reg = <2>;
> +					sensor-type = "TACH";
> +				};
> +				channel@5 {
> +					reg = <5>;
> +					sensor-type = "TACH";
> +				};

[Severity: Low]
Does the maxim,max31790 device tree binding support these channel child
nodes and the sensor-type property?

The upstream device tree binding schema explicitly rejects child nodes
matching channel@[0-9]+ and the sensor-type property, which leads to
validation failures during make dtbs_check. 

Additionally, the kernel driver (drivers/hwmon/max31790.c) does not 
appear to parse these properties, making them dead configuration.

> +			};
> +
> +			hwmon: hwmon@23 {

[ ... ]

> +&i2c7 {
> +	status = "okay";
> +	bus-frequency = <100000>;
> +	multi-master;
> +	i2c-scl-clk-low-timeout-us = <31744>;

[Severity: Low]
Is the i2c-scl-clk-low-timeout-us property supported by the ASPEED I2C
controller?

The device tree binding schema (aspeed,i2c.yaml) does not allow this 
property, which causes a schema validation warning. Furthermore, the 
i2c-aspeed driver does not seem to read this property (it is typically 
used by drivers like i2c-mpc). 

Should this property be removed to avoid dead configuration and validation 
warnings?

> +
> +	/* USB Debug Connector */
> +	ipmb@10 {
> +		compatible = "ipmb-dev";
> +		reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
> +		i2c-protocol;
> +	};
> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260929075106.74731-1-suwangquanta@gmail.com?part=2