Re: [PATCH v7 5/6] dt-bindings: PCI: spacemit: Introduce Spacemit K3 PCIe host controller

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: pci: spacemit: K3 incorrectly restricted to 'msi' interrupt
--

commit f1407822dae59764a20613a52957242f9229a513
Author: Inochi Amaoto <inochiama@gmail.com>

dt-bindings: PCI: spacemit: Introduce Spacemit K3 PCIe host controller

Add binding support for the PCIe controller on the SpacemiT K3 SoC.
This controller is almost a standard Synopsys DesignWare PCIe IP,
with some extra link and reset state control.

> diff --git a/Documentation/devicetree/bindings/pci/spacemit,k1-pcie-host.yaml b/Documentation/devicetree/bindings/pci/spacemit,k1-pcie-host.yaml
> index c4c00b5fcdc0c..af32e427c0c5d 100644
> --- a/Documentation/devicetree/bindings/pci/spacemit,k1-pcie-host.yaml
> +++ b/Documentation/devicetree/bindings/pci/spacemit,k1-pcie-host.yaml
[ ... ]
> @@ -66,6 +70,8 @@ properties:
>    interrupt-names:
>      const: msi
>  

[Severity: Medium]
Since this top-level constraint applies to all compatible strings, doesn't it
prevent the K3 variant (which uses an external MSI controller) from defining
its required standard PCIe interrupts?

If a 'spacemit,k3-pcie' device tree node adds standard PCIe host interrupts,
running 'make dt_binding_check' triggers a validation failure because the
global constraints limit the list to exactly one MSI interrupt. A correct
hardware description specifying standard DWC interrupts (e.g., 'aer', 'pme',
'intx') will fail schema validation.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260929083755.458238-1-inochiama@gmail.com?part=5