Re: [PATCH v4 3/7] arm64: dts: qcom: nord-rrd: Enable ADSP and CDSPs

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] dts: identical firmware-name for multiple distinct DSP cores
--

commit bd06b63b7bb11c940c1decfb487bb0de89250712
Author: Shawn Guo <shengchao.guo@oss.qualcomm.com>

arm64: dts: qcom: nord-rrd: Enable ADSP and CDSPs

This commit enables ADSP and CDSP remoteproc cores on the Nord RRD board.
It configures the firmware names and sets the status to okay for adsp,
cdsp0, cdsp1, cdsp2, and cdsp3.

> diff --git a/arch/arm64/boot/dts/qcom/nord-rrd.dts b/arch/arm64/boot/dts/qcom/nord-rrd.dts
> index 3673003c8b213..0b0acd33a2e19 100644
> --- a/arch/arm64/boot/dts/qcom/nord-rrd.dts
> +++ b/arch/arm64/boot/dts/qcom/nord-rrd.dts
[ ... ]
> +&remoteproc_cdsp0 {
> +	firmware-name = "qcom/nord/cdsp.mbn",
> +			"qcom/nord/cdsp_dtb.mbn";
> +
> +	status = "okay";
> +};
> +
> +&remoteproc_cdsp1 {
> +	firmware-name = "qcom/nord/cdsp.mbn",
> +			"qcom/nord/cdsp_dtb.mbn";
> +
> +	status = "okay";
> +};
> +
> +&remoteproc_cdsp2 {
> +	firmware-name = "qcom/nord/cdsp.mbn",
> +			"qcom/nord/cdsp_dtb.mbn";
> +
> +	status = "okay";
> +};
> +
> +&remoteproc_cdsp3 {
> +	firmware-name = "qcom/nord/cdsp.mbn",
> +			"qcom/nord/cdsp_dtb.mbn";

[Severity: High]
Will cdsp1, cdsp2, and cdsp3 fail to load their firmware during boot?

In Qualcomm platforms, distinct remoteproc instances are backed by
different TrustZone Peripheral Authentication Service (PAS) IDs and are
assigned disjoint reserved physical memory regions.

Reusing cdsp.mbn and cdsp_dtb.mbn across all four cores means that cdsp1,
cdsp2, and cdsp3 will likely fail either the ELF segment physical address
checks in qcom_mdt_load() (because the ELF p_paddr will fall outside the
core's reserved memory region) or TrustZone signature verification.

Should these nodes use core-specific names (e.g., cdsp1.mbn, cdsp2.mbn)
matching standard multi-DSP firmware naming conventions instead?

> +
> +	status = "okay";
> +};
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260929155152.1898666-1-shengchao.guo@oss.qualcomm.com?part=3