Re: [PATCH net-next v24 04/10] mfd: an8855: Add support for Airoha AN8855 Switch

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] mfd: airoha-an8855: violates MFD naming conventions for private structures
--

commit 74bc32f30a5a15b059bad776dd3ef21cad2cb09f
Author: Christian Marangi <ansuelsmth@gmail.com>

mfd: an8855: Add support for Airoha AN8855 Switch

This commit adds support for the Airoha AN8855 Switch, which includes a DSA
switch and an NVMEM provider. It also uses the mdio-regmap driver to
register a regmap for each internal PHY.

> diff --git a/drivers/mfd/airoha-an8855.c b/drivers/mfd/airoha-an8855.c
> new file mode 100644
> index 0000000000000..cd5791ef436d9
> --- /dev/null
> +++ b/drivers/mfd/airoha-an8855.c
[ ... ]
> +#define AN8855_MAX_PHY_PORT		5
> +
> +struct an8855_core_priv {
> +	struct mii_bus *bus;

[Severity: Low]
Does this struct name violate the MFD subsystem naming conventions? The MFD
guidelines require private data structure names to prefer using the device
name directly (e.g., struct an8855) rather than using generic suffixes like
priv or info.

> +	struct mii_bus *phy_bus;
> +	unsigned int switch_addr;
> +	u16 current_page;
> +};
> +
> +struct an8855_phy_priv {
> +	u8 addr;
> +	struct an8855_core_priv *core;
> +};
[ ... ]
> +static int an8855_core_probe(struct mdio_device *mdiodev)
> +{
> +	struct an8855_phy_bus phy_bus_infos[AN8855_MAX_PHY_PORT] = { };
> +	struct device *dev = &mdiodev->dev;
> +	struct an8855_core_priv *priv;

[Severity: Low]
Does this variable name adhere to the MFD guidelines? The guidelines suggest
using ddata for the variable instance instead of a generic name like priv in
an8855_core_probe() and other driver functions.

> +	struct regmap *regmap;
> +	int num_phys;
> +	int i, ret;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260928194511.41878-1-ansuelsmth@gmail.com?part=4