Re: [PATCH net-next v8 03/11] net: ethernet: oa_tc6: Move oa_tc6.c to its own directory

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 4 potential issue(s) to consider:
- [Medium] module: silent renaming breaks user-space ABI expectations
- [Low] kconfig: dropped 'if COMPILE_TEST' exposes internal library in menu
- [Low] maintainers: incomplete coverage for new oa_tc6 directory
- [Low] kbuild: incorrect use of assignment operator := for obj-* variables
--

commit 2a2bc9b290cac06ae77b59d4713ff2993761f061
Author: Selvamani Rajagopal <Selvamani.Rajagopal@onsemi.com>

net: ethernet: oa_tc6: Move oa_tc6.c to its own directory

This commit moves the oa_tc6.c driver into a newly created
drivers/net/ethernet/oa_tc6 directory. This restructuring prepares the
subsystem for additional files that will support hardware timestamps and
PTP APIs for the OPEN Alliance 10BASE-T1x Serial Interface.

> diff --git a/MAINTAINERS b/MAINTAINERS
> index 64da809e46021..541ed016144d8 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -20457,7 +20457,7 @@ M:	Parthiban Veerasooran <parthiban.veerasooran@microchip.com>
>  L:	netdev@vger.kernel.org
>  S:	Maintained
>  F:	Documentation/networking/oa-tc6-framework.rst
> -F:	drivers/net/ethernet/oa_tc6.c
> +F:	drivers/net/ethernet/oa_tc6/oa_tc6*

[Severity: Low]
Does this wildcard pattern inadvertently exclude the new Kconfig and
Makefile added to this directory? Since they do not start with oa_tc6,
maintainer tooling might fail to automatically copy the maintainer on
patches touching these build files.

[ ... ]

> diff --git a/drivers/net/ethernet/oa_tc6/Kconfig b/drivers/net/ethernet/oa_tc6/Kconfig
> new file mode 100644
> index 0000000000000..97345f345fb9f
> --- /dev/null
> +++ b/drivers/net/ethernet/oa_tc6/Kconfig
> @@ -0,0 +1,16 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +#
> +# OA TC6 10BASE-T1x MAC-PHY configuration
> +#
> +
> +config OA_TC6
> +	tristate "OPEN Alliance TC6 10BASE-T1x MAC-PHY support"

[Severity: Low]
Is the removal of the if COMPILE_TEST condition intentional? By dropping
this condition on the prompt without removing the prompt entirely, the
internal framework library becomes unconditionally visible, which might
needlessly pollute the networking drivers menu for users configuring the
kernel.

> +	depends on SPI
> +	select PHYLIB

[ ... ]

> diff --git a/drivers/net/ethernet/oa_tc6/Makefile b/drivers/net/ethernet/oa_tc6/Makefile
> new file mode 100644
> index 0000000000000..f24aae852ef27
> --- /dev/null
> +++ b/drivers/net/ethernet/oa_tc6/Makefile
> @@ -0,0 +1,7 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +#
> +# Makefile for OA TC6 10BASE-T1x MAC-PHY
> +#
> +
> +obj-$(CONFIG_OA_TC6) := oa_tc6_mod.o

[Severity: Low]
Does the use of the assignment operator := instead of the standard +=
cause issues with Kbuild? While it compiles because it is currently the
only entry in this specific Makefile, it overwrites the Kbuild accumulator
variable and could silently drop any previously defined targets if the file
is expanded in the future.

[Severity: Medium]
Could renaming the final module object to oa_tc6_mod break user-space ABI
expectations? The kernel module changes name from oa_tc6.ko to oa_tc6_mod.ko,
which might break modprobe configuration, modules.dep, blacklisting rules,
and sysfs paths under /sys/module/ that rely on the old name. 

To avoid the Kbuild target conflict between the module and the C source
file, would it be better to rename the C source file (e.g., to oa_tc6_main.c)
instead of renaming the resulting module?

> +oa_tc6_mod-objs := oa_tc6.o

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260928-s2500-mac-phy-support-v8-0-7e011aacc309@onsemi.com?part=3