Devicetree
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Tim Kuo <Tim.Kuo@mediatek.com>
Cc: Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	 Matthias Brugger <matthias.bgg@gmail.com>,
	 AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
	 linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	 linux-mediatek@lists.infradead.org,
	Steven Liu <Steven.Liu@mediatek.com>,
	 Sky Huang <Skylake.Huang@mediatek.com>
Subject: Re: [PATCH v2 1/2] spi: dt-bindings: add SPI IPM v59 compatible for mt7987 and mt7989
Date: Wed, 30 Sep 2026 12:36:21 +0200	[thread overview]
Message-ID: <20260930-enchanted-phenomenal-cassowary-80cdfb@quoll> (raw)
In-Reply-To: <20260929062516.416368-1-Tim.Kuo@mediatek.com>

On Tue, Sep 29, 2026 at 02:25:15PM +0800, Tim Kuo wrote:
> MTK mt7987 and mt7989 SPI hardware has been updated to IPM v59 SPI IP and
> it differs from earlier IPM designs, most visibly in the tick delay field
> of SPI_CMD_REG, so it needs its own fallback compatible rather than reusing
> "mediatek,spi-ipm".
> 
> Signed-off-by: Tim Kuo <Tim.Kuo@mediatek.com>
> ---
> v2: Add mt7987 and mt7989 real device compatible
> 
>  .../devicetree/bindings/spi/mediatek,spi-mt65xx.yaml         | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml b/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml
> index 3bf3eb1f8728..d2c740572d85 100644
> --- a/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml
> +++ b/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml
> @@ -39,6 +39,11 @@ properties:
>                - mediatek,mt7988-spi-single
>                - mediatek,mt8188-spi-ipm
>            - const: mediatek,spi-ipm
> +      - items:
> +          - enum:
> +              - mediatek,mt7987-spi
> +              - mediatek,mt7989-spi
> +          - const: mediatek,spi-ipm-v59

No, look at the binding and recent commits. This should be a specific
compatible. Git history easily tells you that.

Best regards,
Krzysztof


  parent reply	other threads:[~2026-09-30 10:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-29  6:25 [PATCH v2 1/2] spi: dt-bindings: add SPI IPM v59 compatible for mt7987 and mt7989 Tim Kuo
2026-09-29  6:25 ` [PATCH v2 2/2] spi: mt65xx: support wider tick delay field on IPM v59 Tim Kuo
2026-09-30 10:36 ` Krzysztof Kozlowski [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-10-01  8:15 [PATCH v2 1/2] spi: dt-bindings: add SPI IPM v59 compatible for mt7987 and mt7989 Tim Kuo (郭廷笙)
2026-10-01  8:21 Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260930-enchanted-phenomenal-cassowary-80cdfb@quoll \
    --to=krzk@kernel.org \
    --cc=Skylake.Huang@mediatek.com \
    --cc=Steven.Liu@mediatek.com \
    --cc=Tim.Kuo@mediatek.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=matthias.bgg@gmail.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox