Re: [PATCH v7 2/6] dt-bindings: soc: samsung: exynos-pmu: Require pmu-intr-gen-syscon for Exynos850

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: incorrect reboot-mode restrictions applied to Exynos850
--

commit f0529e2252a91a7f009c0becdb948b0784d4d52f
Author: Alexey Klimov <alexey.klimov@linaro.org>

dt-bindings: soc: samsung: exynos-pmu: Require pmu-intr-gen-syscon for Exynos850

This commit updates the Exynos PMU schema to mandate the
google,pmu-intr-gen-syscon property for the samsung,exynos850-pmu compatible.
This ensures the hardware is correctly described for the driver to obtain the
syscon regmap.

> diff --git a/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml b/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml
> --- a/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml
> +++ b/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml
> @@ -196,6 +196,7 @@ allOf:
>            contains:
>              enum:
>                - google,gs101-pmu
> +              - samsung,exynos850-pmu

[Severity: Low]
By appending samsung,exynos850-pmu to the google,gs101-pmu conditional block
to enforce the syscon property, does this unintentionally apply Google
Pixel-specific reboot-mode constraints to a standard Samsung SoC?

The reboot-mode pattern properties in this block use a negative lookahead
regex to allow only specific modes (like dm-verity-device-corrupted or
reboot-ab-update). Standard Samsung Exynos devices utilize mode-download,
which is explicitly rejected by this GS101 negative lookahead regex.

Should the requirement for google,pmu-intr-gen-syscon for exynos850-pmu be
encapsulated in its own separate conditional block to avoid breaking schema
validation for valid Exynos850 device trees?

>      then:
>        properties:
>          reboot-mode:

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260930-exynos850-cpuhotplug-v7-0-203245826333@linaro.org?part=2