Re: [PATCH v3 1/2] dt-bindings: display: ti, tpd12s015: Convert to DT schema

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

On Thu, Sep 24, 2026 at 04:53:20PM -0500, Rob Herring (Arm) wrote:
> On Wed, 16 Sep 2026 20:32:09 +0800, Quchaosheng wrote:
> > Convert the TPD12S015 HDMI level shifter binding to DT schema.
> > 
> > The TI TPD12S015 is an HDMI companion chip that combines a level shifter
> > and ESD protection circuitry. Document the two ports it exposes between
> > the HDMI transmitter and the connector.
> > 
> > The tpd12s016 is software compatible with the tpd12s015 and is listed as a
> > fallback compatible by am57xx-idk-common.dtsi, so accept it as a fallback
> > of "ti,tpd12s015". The driver matches on "ti,tpd12s015" only, so a board
> > using the tpd12s016 must list both compatibles.
> > 
> > The gpios property takes the three CT CP HPD, LS OE and HPD GPIOs the
> > driver obtains through devm_gpiod_get_index(). omap5-igep0050.dts lists the
> > DDC SCL and SDA lines as two further entries, so allow up to five entries
> > and keep the property description focused on the ones the driver uses.
> > 
> > Signed-off-by: Quchaosheng <quchaosheng000406@163.com>
> > ---
> > v3:
> >  - gpios: allow up to five entries. v2 claimed that no in-tree board passes
> >    more than three, but omap5-igep0050.dts passes five: the three control/HPD
> >    lines plus the DDC SCL and SDA lines. The three-entry limit added in v2
> >    therefore broke dtbs_check for that board.
> > 
> > v2:
> >  - Reword the description: the TPD12S016 can only be used as a fallback of
> >    "ti,tpd12s015", because the driver matches on "ti,tpd12s015" alone.
> > 
> >  .../bindings/display/ti/ti,tpd12s015.txt      | 44 ---------
> >  .../bindings/display/ti/ti,tpd12s015.yaml     | 93 +++++++++++++++++++
> >  2 files changed, 93 insertions(+), 44 deletions(-)
> >  delete mode 100644 Documentation/devicetree/bindings/display/ti/ti,tpd12s015.txt
> >  create mode 100644 Documentation/devicetree/bindings/display/ti/ti,tpd12s015.yaml
> > 
> 
> Reviewed-by: Rob Herring (Arm) <robh@kernel.org>

I don't think the binding is correct. The two additional GPIOs seem to
be a mistake in the DT source. There's no rationale in this patch to
explain why they're needed.

-- 
Regards,

Laurent Pinchart