Re: [PATCH v1 5/6] dt-bindings: display: panel: Document Hitachi TX10D07VM0BAA and LG LH400WV3 panels

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
- [Medium] dt-bindings: display: panel: hit,tx10d07vm0baa: additionalProperties: false breaks schema references
- [Medium] dt-bindings: display: panel: hit,tx10d07vm0baa: missing mandatory properties in required list
- [Low] dt-bindings: display: panel: hit,tx10d07vm0baa: non-standard avci-supply property
--

commit 2cbee11e4ba06826f435f0f2b5e954558da48338
Author: Svyatoslav Ryhel <clamor95@gmail.com>

dt-bindings: display: panel: Document Hitachi TX10D07VM0BAA and LG LH400WV3 panels

This commit documents the device tree bindings for the Hitachi TX10D07VM0BAA
and LG LH400WV3 MIPI DBI 4" WVGA panels.

> diff --git a/Documentation/devicetree/bindings/display/panel/hit,tx10d07vm0baa.yaml b/Documentation/devicetree/bindings/display/panel/hit,tx10d07vm0baa.yaml
> new file mode 100644
> index 0000000000000..ab839d9e4e111
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/hit,tx10d07vm0baa.yaml
[ ... ]
> +properties:
> +  compatible:
> +    items:
> +      - enum:
> +          - hit,tx10d07vm0baa
> +          - lg,lh400wv3-sd04
> +
> +  avci-supply: true

[Severity: Low]
Is it intentional to use "avci-supply" here? In MIPI DBI/DSI displays, the
standard terminology for the analog/core voltage is usually "vci-supply" or
"avdd-supply". Using "avci-supply" might introduce a typoed or non-standard
name into the stable device tree ABI that drivers will be forced to support.

> +  iovcc-supply: true
> +
> +  reset-gpios: true
> +
> +  backlight: true
> +  port: true
> +
> +required:
> +  - compatible

[Severity: Medium]
Does this list omit mandatory hardware constraints?

Since the panel driver unconditionally requires the power supplies and the port
node, device trees omitting "avci-supply", "iovcc-supply", or "port" will
pass schema validation but fail at runtime. Specifically,
devm_regulator_bulk_get_const requires the power supplies, and
of_graph_get_remote_node in panel_dbi_prepare() returns -ENODEV if the port
node is missing.

> +
> +additionalProperties: false

[Severity: Medium]
Could this strict constraint cause valid device trees to fail schema validation?

Because this schema inherits from panel-common.yaml via a $ref, using
additionalProperties: false instead of unevaluatedProperties: false will
strictly forbid standard panel properties (like rotation, width-mm, or
height-mm) that aren't explicitly listed in this local properties block.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260930070535.47130-1-clamor95@gmail.com?part=5