Re: [PATCH net-next v13 2/9] dt-bindings: net: lan9645x: add LAN9645X switch bindings

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: strict property validation disabled by additionalProperties: true
--

commit 37a55f2415392987ad4b328233f6c32282b21103
Author: Jens Emil Schulz Østergaard <jensemil.schulzostergaard@microchip.com>

dt-bindings: net: lan9645x: add LAN9645X switch bindings
    
This commit adds bindings for the LAN9645X switch, which uses a fallback
compatible for the smallest SKU microchip,lan96455s-switch. The switch is a
child of an externally controlled parent that hands out one regmap per
register target.

> diff --git a/Documentation/devicetree/bindings/net/dsa/microchip,lan96455s-switch.yaml b/Documentation/devicetree/bindings/net/dsa/microchip,lan96455s-switch.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/dsa/microchip,lan96455s-switch.yaml
[ ... ]
> +  ethernet-ports:
> +    type: object
> +    additionalProperties: true
> +    patternProperties:
> +      "^(ethernet-)?port@[0-8]$":
> +        type: object
> +        description: Ethernet switch ports
> +        additionalProperties: true
> +
> +        allOf:
> +          - if:
> +              properties:
> +                phy-mode:

[Severity: Low]
Does setting additionalProperties: true here introduce a validation regression
by unintentionally defeating the unevaluatedProperties: false strictness
checks inherited from dsa.yaml?

Because additionalProperties: true causes dt-schema to mark all unknown
properties as evaluated, it allows any undefined or misspelled properties
inside the child port nodes to silently pass validation.

Could this also cause a regression in the conditional if-then logic below?
If restricted properties like rx-internal-delay-ps are specified on
non-RGMII ports, the if condition fails and the constraint is skipped, but
instead of being rejected, the property is silently allowed unrestricted by
additionalProperties: true.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260929-dsa_lan9645x_switch_driver_base-v13-0-827c2d3617f2@microchip.com?part=2