From: sashiko-bot@kernel.org
To: "Wenmeng Liu" <wenmeng.liu@oss.qualcomm.com>
Cc: media-ci@linuxtv.org, robh@kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v6 1/2] dt-bindings: media: i2c: Add Samsung S5KJN5 image sensor
Date: Wed, 30 Sep 2026 08:13:19 +0000 [thread overview]
Message-ID: <20260930081320.02C231F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260930-sk5jn5-v6-1-517c9b34008a@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: missing vddio-supply in required array
--
commit da52fd45ecb4a0907c160f92eb2fa19fe81352bd
Author: Wenmeng Liu <wenmeng.liu@oss.qualcomm.com>
dt-bindings: media: i2c: Add Samsung S5KJN5 image sensor
This commit adds device tree bindings for the Samsung S5KJN5, a 50 MP 10-bit
RAW MIPI CSI-2 image sensor controlled over CCI.
> diff --git a/Documentation/devicetree/bindings/media/i2c/samsung,s5kjn5.yaml b/Documentation/devicetree/bindings/media/i2c/samsung,s5kjn5.yaml
> new file mode 100644
> index 0000000000000..fedb274679cd1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/samsung,s5kjn5.yaml
[ ... ]
> +properties:
[ ... ]
> + vddio-supply:
> + description:
> + 1.8 volt I/O voltage supply (VDD18). Required for both 1.8 and 1.2 volt
> + I/O operation.
> +
> + vddd-supply:
> + description: Digital core voltage supply, 1.0 volts.
[ ... ]
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - port
[Severity: Low]
Should vddio-supply be included in this required list?
The property description for vddio-supply explicitly states it is required
for both 1.8 and 1.2 volt I/O operation, but omitting it from the required
array allows incomplete device trees to silently pass schema validation.
Are other core voltages like vdda-supply and vddd-supply also strictly
required for operation and missing from this list?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260930-sk5jn5-v6-0-517c9b34008a@oss.qualcomm.com?part=1
next prev parent reply other threads:[~2026-09-30 8:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-30 8:08 [PATCH v6 0/2] media: i2c: Add Samsung S5KJN5 image sensor Wenmeng Liu
2026-09-30 8:08 ` [PATCH v6 1/2] dt-bindings: " Wenmeng Liu
2026-09-30 8:13 ` sashiko-bot [this message]
2026-09-30 8:08 ` [PATCH v6 2/2] media: i2c: Add Samsung S5KJN5 image sensor driver Wenmeng Liu
2026-09-30 8:23 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260930081320.02C231F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=media-ci@linuxtv.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=wenmeng.liu@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox