Re: [PATCH] dt-bindings: hwmon: pmbus: mps,mpq8785: add #thermal-sensor-cells

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: incorrect #thermal-sensor-cells constraint for single-sensor device
--

commit e3f74468edb24a9bcc5d029cc615555210a46a78
Author: Vincent Jardin <vjardin@free.fr>

dt-bindings: hwmon: pmbus: mps,mpq8785: add #thermal-sensor-cells

This patch adds the #thermal-sensor-cells property to the mpq8785 binding
schema to allow referencing the device as a thermal sensor. It sets the
cell count to 1 to match the 1-based sensor index used internally by the
PMBus core.

> diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml
> --- a/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml
[ ... ]
> @@ -34,6 +34,9 @@ properties:
>      maximum: 4095
>      default: 706
>  
> +  "#thermal-sensor-cells":
> +    const: 1

[Severity: Medium]
Is it correct to set the cell count constraint to 1 for this hardware?

The Devicetree specification generally mandates that single-sensor devices
use a cell count of 0, as no index is needed to identify the sensor. By
forcing this to 1, it appears we might be baking a Linux-specific driver
quirk (the PMBus core's internal 1-based index) into the OS-agnostic
hardware description ABI.

Would it be better to map a Devicetree ID of 0 to the internal hwmon index 1
within the driver code itself, rather than requiring device tree authors to
pass a factually incorrect dummy index in their thermal-sensors phandle?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260930-for-upstream-dt-mpq8785-thermal-sensor-cells-v1-1-6573c765eef8@free.fr?part=1