From: sashiko-bot@kernel.org
To: Biju <biju.das.au@gmail.com>
Cc: conor+dt@kernel.org, wsa+renesas@sang-engineering.com,
devicetree@vger.kernel.org, robh@kernel.org
Subject: Re: [PATCH v4 8/9] arm64: dts: renesas: Add DSI overlay for RZ/G3L SMARC EVK with ADV7535
Date: Wed, 30 Sep 2026 14:41:36 +0000 [thread overview]
Message-ID: <20260930144136.D10851F00898@smtp.kernel.org> (raw)
In-Reply-To: <20260930133257.23210-9-biju.das.jz@bp.renesas.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] build: missing base DT nodes 'dsi' and 'du' break composite DTB generation
--
commit 07c28a5a092963d3ce032fe9a165d2ef8166fc2f
Author: Biju Das <biju.das.jz@bp.renesas.com>
arm64: dts: renesas: Add DSI overlay for RZ/G3L SMARC EVK with ADV7535
Add a Device Tree overlay (r9a08g046l48-smarc-dsi-adv7535.dtso) for the
RZ/G3L (R9A08G046) SMARC EVK board to support DSI-to-HDMI output via the
Analog Devices ADV7535 HDMI transmitter.
> diff --git a/arch/arm64/boot/dts/renesas/Makefile b/arch/arm64/boot/dts/renesas/Makefile
> index 8bf155badd111..8c6a448907151 100644
> --- a/arch/arm64/boot/dts/renesas/Makefile
> +++ b/arch/arm64/boot/dts/renesas/Makefile
> @@ -187,6 +187,9 @@ r9a08g045s33-smarc-pmod1-type-3a-dtbs := r9a08g045s33-smarc.dtb r9a08g045s33-sma
> dtb-$(CONFIG_ARCH_R9A08G045) += r9a08g045s33-smarc-pmod1-type-3a.dtb
>
> dtb-$(CONFIG_ARCH_R9A08G046) += r9a08g046l48-smarc.dtb
> +dtb-$(CONFIG_ARCH_R9A08G046) += r9a08g046l48-smarc-dsi-adv7535.dtbo
> +r9a08g046l48-smarc-dsi-adv7535-dtbs := r9a08g046l48-smarc.dtb r9a08g046l48-smarc-dsi-adv7535.dtbo
> +dtb-$(CONFIG_ARCH_R9A08G046) += r9a08g046l48-smarc-dsi-adv7535.dtb
[Severity: Low]
Will this composite DTB generation fail and halt the build process?
The fdtoverlay tool requires that target nodes exist in the base DTB. Because
the labels referenced in the overlay do not exist in the base DTB, it appears
this will break make dtbs for the architecture.
[ ... ]
> diff --git a/arch/arm64/boot/dts/renesas/r9a08g046l48-smarc-dsi-adv7535.dtso b/arch/arm64/boot/dts/renesas/r9a08g046l48-smarc-dsi-adv7535.dtso
> new file mode 100644
> index 0000000000000..1e1ebafe24398
> --- /dev/null
> +++ b/arch/arm64/boot/dts/renesas/r9a08g046l48-smarc-dsi-adv7535.dtso
> @@ -0,0 +1,138 @@
> +// SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
[ ... ]
> +&dsi {
> + status = "okay";
[Severity: Low]
Does this target label actually exist?
This fragment targets the &dsi label, which appears to be missing from the
R9A08G046 base device tree.
[ ... ]
> +&du {
> + status = "okay";
> +};
[Severity: Low]
Does this target label actually exist?
This fragment targets the &du (Display Unit) label, which also appears to
be missing from the R9A08G046 base device tree.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260930133257.23210-1-biju.das.jz@bp.renesas.com?part=8
next prev parent reply other threads:[~2026-09-30 14:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-30 13:32 [PATCH v4 0/9] Add support for DU, LVDS and DSI on the Renesas RZ/G3L SoC Biju
2026-09-30 13:32 ` [PATCH v4 8/9] arm64: dts: renesas: Add DSI overlay for RZ/G3L SMARC EVK with ADV7535 Biju
2026-09-30 14:41 ` sashiko-bot [this message]
2026-09-30 13:32 ` [PATCH v4 9/9] arm64: dts: renesas: Add LVDS overlay for RZ/G3L SMARC EVK with ITE6263 Biju
2026-09-30 14:53 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260930144136.D10851F00898@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=biju.das.au@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox