Re: [PATCH v10 1/6] dt-bindings: rtc: Add pinctrl for S35390A

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: missing #clock-cells in required list
--

commit 7dd7db3e76b5a02a9adebaf8cfe85d348334a1ca
Author: Markus Probst <markus.probst@posteo.de>

dt-bindings: rtc: Add pinctrl for S35390A

This commit moves the devicetree bindings for sii,s35390a into its own file
and adds properties to configure individual pins via pinctrl for wakeup
alarms.

> diff --git a/Documentation/devicetree/bindings/rtc/sii,s35390a.yaml b/Documentation/devicetree/bindings/rtc/sii,s35390a.yaml
> new file mode 100644
> index 0000000000000..f86572e9faffe
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rtc/sii,s35390a.yaml
[ ... ]
> +  wakeup-source: true
> +
> +  "#clock-cells":
> +    const: 1
> +
> +patternProperties:
[ ... ]
> +        required:
> +          - pins
> +          - function
> +
> +required:
> +  - compatible
> +  - reg

[Severity: Medium]
Looking at the required properties list in sii,s35390a.yaml, shouldn't
"#clock-cells" be included here to enforce the clock provider constraints?
By omitting it, the schema allows incomplete device tree nodes to pass
validation silently, which might cause drivers or dependent subsystems to
fail at runtime when they attempt to use the undocumented functionality.

> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        rtc@30 {
> +            compatible = "sii,s35390a";
> +            reg = <0x30>;

[Severity: Medium]
Does this example node in sii,s35390a.yaml need to demonstrate the
"#clock-cells" property? If it is a required provider property, the
example should include it to properly pass dt_binding_check validation.

> +            pinctrl-0 = <&rtc_pins_default>;
> +            pinctrl-names = "default";
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260930-rtc_s35390a_int1-v10-0-e7b1cbc50a7b@posteo.de?part=1