From: sashiko-bot@kernel.org
To: "Nora Schiffer" <nora.schiffer@ew.tq-group.com>
Cc: lee@kernel.org, linux-leds@vger.kernel.org, conor+dt@kernel.org,
robh@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v4 10/10] leds: pca995x: Add support for group brightness control
Date: Wed, 30 Sep 2026 16:03:14 +0000 [thread overview]
Message-ID: <20260930160315.2F2811F0089A@smtp.kernel.org> (raw)
In-Reply-To: <45706e11ea287c92de3408991a3c620472669b5d.1790684839.git.nora.schiffer@ew.tq-group.com>
> When LEDs are set to PWM mode with group control enabled, their
> brightness can control using a global "group PWM" setting, modulating
> the individual LEDs' brightness with a second PWM running at a different
> frequency. This lowers the minimum duty cycle from 1/256 to 1/65536
> (averaged over the modulated signal). Group brightness control is
> particularly useful to adjust for different levels of ambient light.
>
> For simplicity, group PWM mode is always enabled, with the reset default
> of 255 as group brightness. This reduces the effective duty cycle by
> 1/256 at all individual brightness levels (the individual PWM signals
> are modulated with the 255/256 duty cycle group PWM), which should be
> imperceptible.
>
> Signed-off-by: Nora Schiffer <nora.schiffer@ew.tq-group.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1790684839.git.nora.schiffer@ew.tq-group.com?part=10
prev parent reply other threads:[~2026-09-30 16:03 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-30 14:25 [PATCH v4 00/10] leds: pca995x: Minor fixes; reset, output-gain, error reporting and group brightness support Nora Schiffer
2026-09-30 14:25 ` [PATCH v4 01/10] dt-bindings: leds: pca995x: Describe reset-gpios property Nora Schiffer
2026-09-30 15:02 ` sashiko-bot
2026-09-30 14:25 ` [PATCH v4 02/10] dt-bindings: leds: pca995x: Describe nxp,output-gain property Nora Schiffer
2026-09-30 15:09 ` sashiko-bot
2026-09-30 14:25 ` [PATCH v4 03/10] leds: pca995x: Fix maximum LED index for 16-channel variants Nora Schiffer
2026-09-30 14:58 ` Griffin Kroah-Hartman
2026-09-30 15:15 ` sashiko-bot
2026-09-30 14:25 ` [PATCH v4 04/10] leds: pca995x: Fix fwnode handle leaks in error paths Nora Schiffer
2026-09-30 15:24 ` sashiko-bot
2026-09-30 14:25 ` [PATCH v4 05/10] leds: pca995x: Write global registers before creating LED devices Nora Schiffer
2026-09-30 15:33 ` sashiko-bot
2026-09-30 14:25 ` [PATCH v4 06/10] leds: pca995x: Add support for reset GPIO Nora Schiffer
2026-09-30 15:37 ` sashiko-bot
2026-09-30 14:25 ` [PATCH v4 07/10] leds: pca995x: Make output gain configurable Nora Schiffer
2026-09-30 15:41 ` sashiko-bot
2026-09-30 14:25 ` [PATCH v4 08/10] leds: pca995x: Add sysfs files for error reporting Nora Schiffer
2026-09-30 15:48 ` sashiko-bot
2026-10-01 8:03 ` Nora Schiffer
2026-09-30 14:25 ` [PATCH v4 09/10] leds: pca995x: Do not use full on LED mode Nora Schiffer
2026-09-30 15:54 ` sashiko-bot
2026-09-30 14:25 ` [PATCH v4 10/10] leds: pca995x: Add support for group brightness control Nora Schiffer
2026-09-30 16:03 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260930160315.2F2811F0089A@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=nora.schiffer@ew.tq-group.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox