From: sashiko-bot@kernel.org
To: "Vincent Jardin" <vjardin@free.fr>
Cc: devicetree@vger.kernel.org, conor+dt@kernel.org,
linux-hwmon@vger.kernel.org, robh@kernel.org
Subject: Re: [PATCH v2 2/2] dt-bindings: hwmon: pmbus: mps,mpq8785: add #thermal-sensor-cells
Date: Thu, 01 Oct 2026 07:32:51 +0000 [thread overview]
Message-ID: <20261001073252.403CF1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20261001-for-upstream-dt-mpq8785-thermal-sensor-cells-v2-2-07d368dcc662@free.fr>
> From: Vincent Jardin <vjardin@free.fr>
>
> Since commit
> 3aa74796cfd0 ("hwmon: (pmbus) Register with thermal for PSC_TEMPERATURE")
> the PMBus core calls devm_thermal_of_zone_register() for every
> temperature input, so the devices of this binding can be referenced as
> thermal sensors.
>
> By code review, it should work for the MPQ and MPM device bindings.
> They register a single page with PMBUS_HAVE_TEMP through
> pmbus_do_probe(), it means that one device has one
> temperature input, temp1.
>
> The PMBus core registers the first temperature input as sensor 0, so no
> cell is needed.
>
> Signed-off-by: Vincent Jardin <vjardin@free.fr>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261001-for-upstream-dt-mpq8785-thermal-sensor-cells-v2-0-07d368dcc662@free.fr?part=2
next prev parent reply other threads:[~2026-10-01 7:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-01 7:28 [PATCH v2 0/2] hwmon: pmbus: 0-based thermal sensor index, mps,mpq8785 #thermal-sensor-cells Vincent Jardin via B4 Relay
2026-10-01 7:28 ` [PATCH v2 1/2] hwmon: (pmbus/core) Register the thermal sensors with a 0-based index Vincent Jardin via B4 Relay
2026-10-01 7:34 ` sashiko-bot
2026-10-01 7:28 ` [PATCH v2 2/2] dt-bindings: hwmon: pmbus: mps,mpq8785: add #thermal-sensor-cells Vincent Jardin via B4 Relay
2026-10-01 7:32 ` sashiko-bot [this message]
2026-10-01 19:19 ` Conor Dooley
2026-10-01 21:43 ` Vincent Jardin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261001073252.403CF1F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=vjardin@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox