From: sashiko-bot@kernel.org
To: "Radu Sabau" <radu.sabau@analog.com>
Cc: robh@kernel.org, devicetree@vger.kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: iio: imu: Add bindings for ADI ADIS16607
Date: Thu, 01 Oct 2026 09:15:07 +0000 [thread overview]
Message-ID: <20261001091507.DE0021F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20261001-adis16607-v1-1-9c89cee35d56@analog.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: missing adis16607-1 compatible string claimed in commit
--
commit 1526b61216e35843822d77abd26ffb5b695890a2
Author: Radu Sabau <radu.sabau@analog.com>
dt-bindings: iio: imu: Add bindings for ADI ADIS16607
This commit adds device tree bindings for the Analog Devices ADIS16607
Precision MEMS Inertial Measurement Unit. It defines the required SPI and
power properties, as well as optional clock, reset, and FIFO configurations.
> Three compatible variants are supported: adis16607-1, adis16607-2,
> and adis16607-3.
[ ... ]
> diff --git a/Documentation/devicetree/bindings/iio/imu/adi,adis16607.yaml b/Documentation/devicetree/bindings/iio/imu/adi,adis16607.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/imu/adi,adis16607.yaml
[ ... ]
> +properties:
> + compatible:
> + enum:
> + - adi,adis16607-2
> + - adi,adis16607-3
[Severity: Medium]
The commit message explicitly claims support for three compatible variants
including adis16607-1. Is it intentional that adi,adis16607-1 is missing
from this enum, or was it accidentally omitted from the binding?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261001-adis16607-v1-0-9c89cee35d56@analog.com?part=1
next prev parent reply other threads:[~2026-10-01 9:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-01 9:11 [PATCH 0/2] iio: imu: Add support for the ADI ADIS16607 Radu Sabau via B4 Relay
2026-10-01 9:11 ` [PATCH 1/2] dt-bindings: iio: imu: Add bindings for " Radu Sabau via B4 Relay
2026-10-01 9:15 ` sashiko-bot [this message]
2026-10-01 9:16 ` Sabau, Radu bogdan
2026-10-01 19:04 ` Conor Dooley
2026-10-05 12:53 ` Sabau, Radu bogdan
2026-10-01 9:11 ` [PATCH 2/2] iio: imu: Add driver for the " Radu Sabau via B4 Relay
2026-10-01 9:26 ` sashiko-bot
2026-10-02 10:38 ` Andy Shevchenko
2026-10-02 11:05 ` Nuno Sá
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261001091507.DE0021F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=radu.sabau@analog.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox