From: sashiko-bot@kernel.org
To: Biju <biju.das.au@gmail.com>
Cc: conor+dt@kernel.org, wsa+renesas@sang-engineering.com,
robh@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v5 8/9] arm64: dts: renesas: Add DSI overlay for RZ/G3L SMARC EVK with ADV7535
Date: Thu, 01 Oct 2026 10:46:28 +0000 [thread overview]
Message-ID: <20261001104628.D68581F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20261001094041.135697-9-biju.das.jz@bp.renesas.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dts: build failure due to undefined dsi and du labels
--
commit 045dc46eb4705fb5d6a8e9c2c09ae5baac2cfba9
Author: Biju Das <biju.das.jz@bp.renesas.com>
arm64: dts: renesas: Add DSI overlay for RZ/G3L SMARC EVK with ADV7535
This commit adds a Device Tree overlay for the RZ/G3L SMARC EVK board to
support DSI-to-HDMI output via the ADV7535 transmitter. It enables the DSI
controller, display unit (DU), HDMI audio, and updates the Makefile to build
the standalone and composite DTBs.
> diff --git a/arch/arm64/boot/dts/renesas/Makefile b/arch/arm64/boot/dts/renesas/Makefile
> index 8bf155badd111..8c6a448907151 100644
> --- a/arch/arm64/boot/dts/renesas/Makefile
> +++ b/arch/arm64/boot/dts/renesas/Makefile
[ ... ]
> @@ -187,6 +187,9 @@ r9a08g045s33-smarc-pmod1-type-3a-dtbs := r9a08g045s33-smarc.dtb r9a08g045s33-sma
> dtb-$(CONFIG_ARCH_R9A08G045) += r9a08g045s33-smarc-pmod1-type-3a.dtb
>
> dtb-$(CONFIG_ARCH_R9A08G046) += r9a08g046l48-smarc.dtb
> +dtb-$(CONFIG_ARCH_R9A08G046) += r9a08g046l48-smarc-dsi-adv7535.dtbo
> +r9a08g046l48-smarc-dsi-adv7535-dtbs := r9a08g046l48-smarc.dtb r9a08g046l48-smarc-dsi-adv7535.dtbo
> +dtb-$(CONFIG_ARCH_R9A08G046) += r9a08g046l48-smarc-dsi-adv7535.dtb
[Severity: Low]
Will this composite DTB rule break the build?
Running make dtbs with CONFIG_ARCH_R9A08G046 attempts to generate the
composite DTB using fdtoverlay. Since the base DTB lacks the dsi and du labels
referenced in the overlay, fdtoverlay will fail with an unresolved reference
error and abort the build process.
> diff --git a/arch/arm64/boot/dts/renesas/r9a08g046l48-smarc-dsi-adv7535.dtso b/arch/arm64/boot/dts/renesas/r9a08g046l48-smarc-dsi-adv7535.dtso
> new file mode 100644
> index 0000000000000..1e1ebafe24398
> --- /dev/null
> +++ b/arch/arm64/boot/dts/renesas/r9a08g046l48-smarc-dsi-adv7535.dtso
[ ... ]
> +&dsi {
> + status = "okay";
[Severity: Low]
Does the base device tree define the dsi label?
It appears this label reference is missing from the base SoC device tree,
which causes the overlay application to fail when building the composite DTB.
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@1 {
> + reg = <1>;
> + dsi_out: endpoint {
> + data-lanes = <1 2 3 4>;
> + remote-endpoint = <&adv7535_in>;
> + };
> + };
> + };
> +};
> +
> +&du {
> + status = "okay";
> +};
[Severity: Low]
Similarly, does the base device tree define the du label?
This unresolved reference will also contribute to the build aborting during
fdtoverlay.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261001094041.135697-1-biju.das.jz@bp.renesas.com?part=8
next prev parent reply other threads:[~2026-10-01 10:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-01 9:40 [PATCH v5 0/9] Add support for DU, LVDS and DSI on the Renesas RZ/G3L SoC Biju
2026-10-01 9:40 ` [PATCH v5 8/9] arm64: dts: renesas: Add DSI overlay for RZ/G3L SMARC EVK with ADV7535 Biju
2026-10-01 10:46 ` sashiko-bot [this message]
2026-10-01 9:40 ` [PATCH v5 9/9] arm64: dts: renesas: Add LVDS overlay for RZ/G3L SMARC EVK with ITE6263 Biju
2026-10-01 10:58 ` sashiko-bot
2026-10-01 10:56 ` [PATCH v5 0/9] Add support for DU, LVDS and DSI on the Renesas RZ/G3L SoC Biju Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261001104628.D68581F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=biju.das.au@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox