From: sashiko-bot@kernel.org
To: "Vikash Garodia" <vikash.garodia@oss.qualcomm.com>
Cc: media-ci@linuxtv.org, devicetree@vger.kernel.org,
conor+dt@kernel.org, robh@kernel.org
Subject: Re: [PATCH v6 1/2] arm64: dts: qcom: shikra: Add Iris video codec node
Date: Thu, 01 Oct 2026 13:50:49 +0000 [thread overview]
Message-ID: <20261001135049.D945E1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20261001-shikra_vpu-v6-1-37143dc1bb9d@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: missing qcom,shikra-venus compatible string in schema
--
commit 72de37a6e4a3d11559749c7b3aae80f415758b83
Author: Vikash Garodia <vikash.garodia@oss.qualcomm.com>
arm64: dts: qcom: shikra: Add Iris video codec node
This commit adds the Iris video codec device tree node for the Shikra
platform. It describes the Iris-based video decoder/encoder block, allowing
the media driver to probe and initialize the hardware.
> diff --git a/arch/arm64/boot/dts/qcom/shikra.dtsi b/arch/arm64/boot/dts/qcom/shikra.dtsi
> index 9823c591b02b1..d2e4db4025dcc 100644
> --- a/arch/arm64/boot/dts/qcom/shikra.dtsi
> +++ b/arch/arm64/boot/dts/qcom/shikra.dtsi
[ ... ]
> @@ -2809,6 +2809,67 @@ adreno_smmu: iommu@59a0000 {
> power-domains = <&gpucc GPU_CX_GDSC>;
> };
>
> + iris: video-codec@5a00000 {
> + compatible = "qcom,shikra-venus", "qcom,qcm2290-venus";
[Severity: Low]
Is this new "qcom,shikra-venus" compatible string documented in the
dt-bindings schema?
It appears to be missing from the corresponding dt-bindings schema (such as
qcom,qcm2290-venus.yaml). This will cause validation failures during
`make dtbs_check`.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261001-shikra_vpu-v6-0-37143dc1bb9d@oss.qualcomm.com?part=1
next prev parent reply other threads:[~2026-10-01 13:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-01 13:41 [PATCH v6 0/2] media: qcom: Add support for the iris codec on shikra Vikash Garodia
2026-10-01 13:41 ` [PATCH v6 1/2] arm64: dts: qcom: shikra: Add Iris video codec node Vikash Garodia
2026-10-01 13:50 ` sashiko-bot [this message]
2026-10-01 13:55 ` Vikash Garodia
2026-10-02 9:14 ` Abel Vesa
2026-10-01 13:41 ` [PATCH v6 2/2] arm64: dts: qcom: shikra-evk: Enable Iris core Vikash Garodia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261001135049.D945E1F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=media-ci@linuxtv.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=vikash.garodia@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox