Devicetree
 help / color / mirror / Atom feed
From: Henrik Grimler <henrik.grimler@axis.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Jesper Nilsson <jesper.nilsson@axis.com>,
	Lars Persson <lars.persson@axis.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Richard Cochran <richardcochran@gmail.com>,
	linux-arm-kernel@axis.com, kernel@axis.com,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org, Henrik Grimler <henrik@grimler.se>
Subject: Re: [PATCH 1/7] ARM: dts: axis: artpec6: avoid _ in node names
Date: Thu, 1 Oct 2026 15:58:29 +0200	[thread overview]
Message-ID: <20261001135829.GA981103@pc67698-2615.sto.se.axis.com> (raw)
In-Reply-To: <3caea146-74ab-42d2-ad9f-d36d1adedc03@kernel.org>

Hi Krzysztof,

On Wed, Sep 30, 2026 at 07:24:43AM +0200, Krzysztof Kozlowski wrote:
> On 28/09/2026 14:04, Henrik Grimler wrote:
> > Node names should preferably not use _, use - instead. Fixes
> > dt-check-style strict mode warnings:
> > 
> >   axis/artpec6.dtsi:91: [node-name] node name "ext_clk" is using discouraged style
> >   axis/artpec6.dtsi:97: [node-name] node name "eth_phy_ref_clk" is using discouraged style
> >   axis/artpec6.dtsi:189: [node-name] node name "pcie_ep" is using discouraged style
> > 
> > Signed-off-by: Henrik Grimler <henrik.grimler@axis.com>
> > ---
> >  arch/arm/boot/dts/axis/artpec6.dtsi | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/arch/arm/boot/dts/axis/artpec6.dtsi b/arch/arm/boot/dts/axis/artpec6.dtsi
> > index 037157e6c5ee..ce642dcc754e 100644
> > --- a/arch/arm/boot/dts/axis/artpec6.dtsi
> > +++ b/arch/arm/boot/dts/axis/artpec6.dtsi
> > @@ -88,13 +88,13 @@ scu@faf00000 {
> >  	};
> >  
> >  	/* Main external clock driving CPU and peripherals */
> > -	ext_clk: ext_clk {
> > +	ext_clk: ext-clk {
> 
> This will change the name of the clock. Did you verify that it is fine?

Good point, the clkctrl driver does not get the clk by this name, and I
have verified on the artpec6-devboard that it can still accesses the
clock without issues. Will add this information to the commit message.

Best regards,
Henrik Grimler

> Best regards,
> Krzysztof

  reply	other threads:[~2026-10-01 13:58 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-28 12:04 [PATCH 0/7] ARM: dts: artpec: cleanup with the help of dt-check-style Henrik Grimler
2026-09-28 12:04 ` [PATCH 1/7] ARM: dts: axis: artpec6: avoid _ in node names Henrik Grimler
2026-09-30  5:24   ` Krzysztof Kozlowski
2026-10-01 13:58     ` Henrik Grimler [this message]
2026-09-28 12:04 ` [PATCH 2/7] ARM: dts: axis: artpec6: align all continued lines Henrik Grimler
2026-09-30  5:30   ` (subset) " Krzysztof Kozlowski
2026-09-30  5:44     ` Krzysztof Kozlowski
2026-09-30  6:22       ` Henrik Grimler
2026-09-30  8:39         ` Krzysztof Kozlowski
2026-09-28 12:04 ` [PATCH 3/7] ARM: dts: axis: artpec6: use multiple tuples in regs and ranges Henrik Grimler
2026-09-28 12:04 ` [PATCH 4/7] ARM: dts: axis: artpec6: sort all properties Henrik Grimler
2026-09-28 12:04 ` [PATCH 5/7] ARM: dts: axis: artpec6: add more blank lines Henrik Grimler
2026-09-28 12:04 ` [PATCH 6/7] ARM: dts: axis: artpec6: put inline comments on same line as entries Henrik Grimler
2026-09-30  5:29   ` Krzysztof Kozlowski
2026-09-28 12:04 ` [PATCH 7/7] ARM: dts: axis: artpec6: add empty lines before empty queue nodes Henrik Grimler
2026-09-30  5:27   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261001135829.GA981103@pc67698-2615.sto.se.axis.com \
    --to=henrik.grimler@axis.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=henrik@grimler.se \
    --cc=jesper.nilsson@axis.com \
    --cc=kernel@axis.com \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=lars.persson@axis.com \
    --cc=linux-arm-kernel@axis.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=richardcochran@gmail.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox