Re: [PATCH v4 2/6] media: dt-bindings: qcom-kaanapali-iris: Add kaanapali video codec binding

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: missing minItems constraint for Kaanapali non-pixel IOMMUs
--

commit 6f9f95b21ddb33d1c70e144093a6e9d9d8fc8379
Author: Vikash Garodia <vikash.garodia@oss.qualcomm.com>

media: dt-bindings: qcom-kaanapali-iris: Add kaanapali video codec binding

This commit introduces device tree bindings for the video encoding and
decoding hardware on the Qualcomm Kaanapali SoC. It creates a new
platform-specific schema for Kaanapali and increases the maximum item
constraints in the common venus schema to accommodate it. It also adds
explicit constraints to existing iris schemas to maintain their fixed
upper bounds.

> diff --git a/Documentation/devicetree/bindings/media/qcom,kaanapali-iris.yaml b/Documentation/devicetree/bindings/media/qcom,kaanapali-iris.yaml
> new file mode 100644
> index 0000000000000..02b3fa3b5e11b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/qcom,kaanapali-iris.yaml
> @@ -0,0 +1,227 @@
[ ... ]
> +  interconnect-names:
> +    items:
> +      - const: cpu-cfg
> +      - const: video-mem
> +
> +  non-pixel:
> +    type: object
> +    properties:
> +      iommus:
> +        maxItems: 3

[Severity: Low]
The commit message notes that the platform-specific schema defines fixed
constraints for these properties. Since the common schema specifies
minItems: 1 for the non-pixel iommus, does this omission of minItems here
allow a configuration with 1 or 2 items to pass validation?

Should there be a minItems: 3 constraint added to enforce the exact
hardware requirement for Kaanapali?

> +
> +  operating-points-v2: true
> +  opp-table:
> +    type: object
> +

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261001-kaanapali-iris-v4-0-642f9ac5e699@oss.qualcomm.com?part=2