Devicetree
 help / color / mirror / Atom feed
From: Sergey Lebedev <lsa.uz@pm.me>
To: Sakari Ailus <sakari.ailus@linux.intel.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Andre Gilerson <andre.gilerson@gmail.com>,
	Dan Scally <dan.scally@ideasonboard.com>
Cc: Hans de Goede <hansg@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	German Pablo Lindo <germanpapulindez@gmail.com>,
	sashiko-bot@kernel.org, linux-media@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v8 0/3] Add support for the Sony IMX681 camera sensor
Date: Fri, 02 Oct 2026 08:25:43 +0000	[thread overview]
Message-ID: <20261002082537.74084-1-lsa.uz@pm.me> (raw)

The Sony IMX681 is the user-facing camera on the Microsoft Surface Pro 11 for
Business (Intel Lunar Lake, IPU7), ACPI device SONY0681. Without a driver the
camera does not appear at all.

  1/3  dt-bindings: media: Add Sony IMX681            (mine)
  2/3  media: i2c: Add Sony IMX681 sensor driver      (Andre's, co-developed)
  3/3  media: ipu-bridge: Add Sony IMX681             (mine)

The driver is Andre's, reverse-engineered from I2C traces taken under
Windows.

Changes in v8
=============

From Andre's review of v7 2/3:
https://lore.kernel.org/all/CAKNG7X8_fNSNKK8FGtm4pey+Pq1PP+38PFTn8O2yP8L04rpcpg@mail.gmail.com/

- The clock comes from devm_v4l2_sensor_clk_get(), and the 19.2 MHz check
  no longer depends on a clock being found. v7 skipped it when
  devm_clk_get_optional() returned NULL, and its comment said INT3472 on
  this machine hands the clock over outside the clk framework. That was
  wrong: the sensor gets INT3472:02-clk at 19.2 MHz through clkdev, as
  v7's own cover letter showed.
- The probe error path calls pm_runtime_dont_use_autosuspend(), as
  remove() does.
- At Andre's suggestion, we are both maintainers, in the binding and in
  MAINTAINERS, and 2/3 carries Co-developed-by for me.

Also:
- Andre's Acked-by on 1/3, from a mail lore does not thread under v7:
  https://lore.kernel.org/all/CAKNG7X9NkbXSnWGR4-79akJ7WiVeGa7D0mC=p1Pz2gTFO4npZw@mail.gmail.com/
  Krzysztof's Reviewed-by is kept: the binding changed only by the second
  maintainer line.
- German's Tested-by on 2/3 is kept. Its only functional changes are
  Andre's two above, which he tested on the same machine, as I did.
- Each patch carries Assisted-by: Claude:claude-opus-5-5.

While this sensor streams, IPU7's CSI-2 receiver logs "Received packet is
too long" once per frame, and the frames are complete. Andre sees the same
with his downstream driver, so it does not come from this series, and he is
looking into it.

Tested on the Surface Pro 11 for Business, on media next 2dcdfb625c3 with
KASAN and lockdep:
- the clock is INT3472:02-clk at 19.2 MHz, with the sensor as consumer;
- v4l2-compliance 46 of 46, no warnings;
- 3844x2640 at 30.01 fps;
- the four flip states give the four Bayer orders, and EBUSY while
  streaming;
- runtime suspend after streaming, and capture after unbind and bind;
- no KASAN or lockdep report from the driver;
- W=1 and sparse clean, dt_binding_check clean.

v7: https://lore.kernel.org/all/20260923211816.89954-1-lsa.uz@pm.me/

Andre Gilerson (1):
  media: i2c: Add Sony IMX681 sensor driver

Sergey Lebedev (2):
  dt-bindings: media: Add Sony IMX681
  media: ipu-bridge: Add Sony IMX681

 .../bindings/media/i2c/sony,imx681.yaml       |  108 ++
 MAINTAINERS                                   |    8 +
 drivers/media/i2c/Kconfig                     |   10 +
 drivers/media/i2c/Makefile                    |    1 +
 drivers/media/i2c/imx681.c                    | 1032 +++++++++++++++++
 drivers/media/pci/intel/ipu-bridge.c          |    2 +
 6 files changed, 1161 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx681.yaml
 create mode 100644 drivers/media/i2c/imx681.c

-- 
2.54.0 (Apple Git-157)



             reply	other threads:[~2026-10-02  8:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-02  8:25 Sergey Lebedev [this message]
2026-10-02  8:25 ` [PATCH v8 1/3] dt-bindings: media: Add Sony IMX681 Sergey Lebedev
2026-10-02  8:26 ` [PATCH v8 2/3] media: i2c: Add Sony IMX681 sensor driver Sergey Lebedev
2026-10-02  9:14   ` sashiko-bot
2026-10-02  9:53   ` Sergey Lebedev
2026-10-02  8:26 ` [PATCH v8 3/3] media: ipu-bridge: Add Sony IMX681 Sergey Lebedev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261002082537.74084-1-lsa.uz@pm.me \
    --to=lsa.uz@pm.me \
    --cc=andre.gilerson@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=dan.scally@ideasonboard.com \
    --cc=devicetree@vger.kernel.org \
    --cc=germanpapulindez@gmail.com \
    --cc=hansg@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=robh@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=sashiko-bot@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox