Re: [PATCH v10 1/6] dt-bindings: spmi: apple,spmi: Add t603x and t8122

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: spmi: apple: missing power-domains in required list for non-always-on SoCs
--

commit 888cdba0f17c299db4b50bbf52f14fcb099ef7c9
Author: Sasha Finkelstein <k@chaosmail.tech>

dt-bindings: spmi: apple,spmi: Add t603x and t8122

This commit adds new t603x and t8122 compatibles to the apple,spmi bindings.
It also introduces optional interrupt properties and adds support for SPMI
controllers that are not always-on.

> diff --git a/Documentation/devicetree/bindings/spmi/apple,spmi.yaml b/Documentation/devicetree/bindings/spmi/apple,spmi.yaml
> index 3e5b14bc8c317..4e73083ecec33 100644
> --- a/Documentation/devicetree/bindings/spmi/apple,spmi.yaml
> +++ b/Documentation/devicetree/bindings/spmi/apple,spmi.yaml
[ ... ]
> @@ -34,10 +37,36 @@ properties:
>    reg:
>      maxItems: 1
>  
> +  interrupts:
> +    maxItems: 1
> +    description: Optional, operates in polled mode if not present
> +
> +  interrupt-controller: true
> +
> +  "#interrupt-cells":
> +    const: 2
> +
> +  power-domains:
> +    maxItems: 1
> +
>  required:
>    - compatible
>    - reg
>  
> +if:
> +  properties:
> +    compatible:
> +      contains:
> +        enum:
> +          - apple,t8122-spmi
> +          - apple,t6030-spmi
> +          - apple,t6031-spmi
> +then:
> +  required:
> +    - interrupt-controller
> +    - "#interrupt-cells"
> +    - interrupts

[Severity: Medium]
Should power-domains be included in this required list?

If a device tree for a non-always-on Apple SoC, such as t8122-spmi or
t6030-spmi, is authored without the power-domains property, the schema
validation will incorrectly accept it as valid due to the missing constraint
in this block.

At runtime, the kernel will fail to attach the power domain, resulting in a
fatal synchronous external abort and system panic when the driver accesses
unpowered registers.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261001-t603x-spmi-v10-0-ff815c66c73f@chaosmail.tech?part=1