From: sashiko-bot@kernel.org
To: "Alexander Stein" <alexander.stein@ew.tq-group.com>
Cc: Frank.Li@kernel.org, devicetree@vger.kernel.org,
imx@lists.linux.dev, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH 7/8] ARM: dts: imx6ull: Add parallel display DT overlay for TQMa6ULLx
Date: Fri, 02 Oct 2026 09:14:45 +0000 [thread overview]
Message-ID: <20261002091446.3571F1F0089A@smtp.kernel.org> (raw)
In-Reply-To: <20261002081417.2092471-8-alexander.stein@ew.tq-group.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dts: Makefile: incorrect dtbo included for fc21 dtb target
--
commit bc626d69455423e37445a45960310a9fe70cea35
Author: Alexander Stein <alexander.stein@ew.tq-group.com>
ARM: dts: imx6ull: Add parallel display DT overlay for TQMa6ULLx
This commit adds parallel display device tree overlays for the TQMa6ULLx board.
It reuses the existing .dtso files from TQMa6ULx for these new targets.
> diff --git a/arch/arm/boot/dts/nxp/imx/Makefile b/arch/arm/boot/dts/nxp/imx/Makefile
> index e86b9c1a63005..5f190900904ab 100644
> --- a/arch/arm/boot/dts/nxp/imx/Makefile
> +++ b/arch/arm/boot/dts/nxp/imx/Makefile
> @@ -427,6 +427,8 @@ imx6ul-tqma6ul2l-mba6ulx-lvds-tm070jvhg33-dtbs += imx6ul-tqma6ul2-mba6ulx.dtb im
> imx6ul-tqma6ul2l-mba6ulx-cdtech-dc44-dtbs += imx6ul-tqma6ul2l-mba6ulx.dtb imx6ul-tqma6ul2-mba6ulx-cdtech-dc44.dtbo
> imx6ul-tqma6ul2l-mba6ulx-cdtech-fc21-dtbs += imx6ul-tqma6ul2l-mba6ulx.dtb imx6ul-tqma6ul2-mba6ulx-cdtech-fc21.dtbo
> imx6ull-tqma6ull2-mba6ulx-lvds-tm070jvhg33-dtbs += imx6ull-tqma6ull2-mba6ulx.dtb imx6ul-tqma6ul2-mba6ulx-lvds-tm070jvhg33.dtbo
> +imx6ull-tqma6ull2-mba6ulx-cdtech-dc44-dtbs += imx6ull-tqma6ull2-mba6ulx.dtb imx6ul-tqma6ul2-mba6ulx-cdtech-dc44.dtbo
> +imx6ull-tqma6ull2-mba6ulx-cdtech-fc21-dtbs += imx6ull-tqma6ull2-mba6ulx.dtb imx6ul-tqma6ul2-mba6ulx-cdtech-dc44.dtbo
[Severity: Medium]
Should this target use the fc21 overlay instead? It looks like it is
incorrectly including imx6ul-tqma6ul2-mba6ulx-cdtech-dc44.dtbo for the
cdtech-fc21 target.
> imx6ull-tqma6ull2l-mba6ulx-lvds-tm070jvhg33-dtbs += imx6ull-tqma6ull2l-mba6ulx.dtb imx6ul-tqma6ul2-mba6ulx-lvds-tm070jvhg33.dtbo
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261002081417.2092471-1-alexander.stein@ew.tq-group.com?part=7
next prev parent reply other threads:[~2026-10-02 9:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-02 8:14 [PATCH 0/8] Display support for TQMa6UL[L]x Alexander Stein
2026-10-02 8:14 ` [PATCH 1/8] ARM: dts: imx6ul: Add LVDS DT overlay for TQMa6ULx Alexander Stein
2026-10-02 14:37 ` Frank Li
2026-10-02 8:14 ` [PATCH 2/8] ARM: dts: imx6ul: Add LVDS DT overlay for TQMa6ULxL Alexander Stein
2026-10-02 9:14 ` sashiko-bot
2026-10-02 9:44 ` Alexander Stein
2026-10-02 8:14 ` [PATCH 3/8] ARM: dts: imx6ull: Add LVDS DT overlay for TQMa6ULLx Alexander Stein
2026-10-02 8:14 ` [PATCH 4/8] ARM: dts: imx6ull: Add LVDS DT overlay for TQMa6ULLxL Alexander Stein
2026-10-02 8:14 ` [PATCH 5/8] ARM: dts: imx6ul: Add parallel display DT overlay for TQMa6ULx Alexander Stein
2026-10-02 8:14 ` [PATCH 6/8] ARM: dts: imx6ul: Add parallel display DT overlay for TQMa6ULxL Alexander Stein
2026-10-02 8:14 ` [PATCH 7/8] ARM: dts: imx6ull: Add parallel display DT overlay for TQMa6ULLx Alexander Stein
2026-10-02 9:14 ` sashiko-bot [this message]
2026-10-02 9:52 ` Alexander Stein
2026-10-02 8:14 ` [PATCH 8/8] ARM: dts: imx6ull: Add parallel display DT overlay for TQMa6ULLxL Alexander Stein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261002091446.3571F1F0089A@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=alexander.stein@ew.tq-group.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox