From: sashiko-bot@kernel.org
To: "Gregor Herburger" <gregor.herburger@linutronix.de>
Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v5 1/5] firmware: raspberrypi: reorder rpi_firmware_property_tag enum
Date: Fri, 02 Oct 2026 09:58:28 +0000 [thread overview]
Message-ID: <20261002095829.5FC8C1F00893@smtp.kernel.org> (raw)
In-Reply-To: <20261002-rpi-tryboot-v5-1-6294c131e583@linutronix.de>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] misc: incomplete enum reordering contradicts commit intent
--
commit ef2bb95b7d295f4ec53aefb9f615706dd192ce98
Author: Gregor Herburger <gregor.herburger@linutronix.de>
firmware: raspberrypi: reorder rpi_firmware_property_tag enum
The enum was once ordered by tag values. The later added tags were added
in a different order. Reorder the tags again.
No functional change intended.
> diff --git a/include/soc/bcm2835/raspberrypi-firmware.h b/include/soc/bcm2835/raspberrypi-firmware.h
> index 975bef529854a..8ad1cdbf5e9f5 100644
> --- a/include/soc/bcm2835/raspberrypi-firmware.h
> +++ b/include/soc/bcm2835/raspberrypi-firmware.h
[ ... ]
> @@ -125,10 +125,10 @@ enum rpi_firmware_property_tag {
> RPI_FIRMWARE_FRAMEBUFFER_SET_VIRTUAL_OFFSET = 0x00048009,
> RPI_FIRMWARE_FRAMEBUFFER_SET_OVERSCAN = 0x0004800a,
> RPI_FIRMWARE_FRAMEBUFFER_SET_PALETTE = 0x0004800b,
> - RPI_FIRMWARE_FRAMEBUFFER_SET_TOUCHBUF = 0x0004801f,
> - RPI_FIRMWARE_FRAMEBUFFER_SET_GPIOVIRTBUF = 0x00048020,
> RPI_FIRMWARE_FRAMEBUFFER_SET_VSYNC = 0x0004800e,
> RPI_FIRMWARE_FRAMEBUFFER_SET_BACKLIGHT = 0x0004800f,
> + RPI_FIRMWARE_FRAMEBUFFER_SET_TOUCHBUF = 0x0004801f,
> + RPI_FIRMWARE_FRAMEBUFFER_SET_GPIOVIRTBUF = 0x00048020,
>
> RPI_FIRMWARE_VCHIQ_INIT = 0x00048010,
[Severity: Low]
Does this actually leave the enum unsorted? 0x0004801f and 0x00048020 are
now placed immediately before 0x00048010, which appears to contradict the
commit message's intent to reorder the tags by their values.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261002-rpi-tryboot-v5-0-6294c131e583@linutronix.de?part=1
next prev parent reply other threads:[~2026-10-02 9:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-02 9:53 [PATCH v5 0/5] firmware: raspberrypi: Add support for the tryboot mode Gregor Herburger
2026-10-02 9:53 ` [PATCH v5 1/5] firmware: raspberrypi: reorder rpi_firmware_property_tag enum Gregor Herburger
2026-10-02 9:58 ` sashiko-bot [this message]
2026-10-02 9:53 ` [PATCH v5 2/5] dt-bindings: raspberrypi,bcm2835-firmware: Include 'reboot-mode.yaml' Gregor Herburger
2026-10-02 9:53 ` [PATCH v5 3/5] firmware: raspberrypi: Add reboot mode support Gregor Herburger
2026-10-02 9:53 ` [PATCH v5 4/5] arm64: dts: broadcom: bcm2712: Add reboot modes to firmware node Gregor Herburger
2026-10-02 9:53 ` [PATCH v5 5/5] arm: dts: broadcom: bcm2835: " Gregor Herburger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261002095829.5FC8C1F00893@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregor.herburger@linutronix.de \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox