Re: [PATCH v5 1/6] dt-bindings: iio: imu: icm42600: Add ICM-42670-P

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] dt-bindings: commit message incorrectly references 'ICM-42670-P' instead of 'ICM-42370-P'
- [Medium] dt-bindings: incorrectly mandates 'interrupts' property for icm42370p
--

commit b386c122ed876ee19ff8c304b5e2727ae3a6b215
Author: Kanak Shilledar <kanak.shilledar@axis.com>

dt-bindings: iio: imu: icm42600: Add ICM-42670-P

This commit adds support for a 3-axis accelerometer to the existing
invensense,icm42600 device tree binding. It updates the device description
and introduces a new compatible string.

> dt-bindings: iio: imu: icm42600: Add ICM-42670-P
> 
> TDK Invensense, ICM-42670-P is a 3-axis accelerometer. The device can
> support I2C, SPI and I3C. This device has very similar properties as
> that of the icm42607/p. Add this device to the existing dt-binding and
> update the description to match the devices.
> 
> Datasheet: https://www.invensense.tdk.com/en-us/products/3-axis/icm-42370-p

[Severity: Medium]
Is there a mismatch between the device name in the commit message and the
actual hardware supported? The subject and body mention ICM-42670-P, but
the datasheet link and the added compatible string use icm42370p.

> diff --git a/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml b/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml
> --- a/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml
> +++ b/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml
[ ... ]
> @@ -81,6 +82,7 @@ allOf:
>          compatible:
>            contains:
>              enum:
> +              - invensense,icm42370p
>                - invensense,icm42600
>                - invensense,icm42602
>                - invensense,icm42605

[Severity: Medium]
Does adding the compatible string to this specific conditional block
incorrectly mandate the interrupts property for this device?

Device tree schema validation will falsely reject valid hardware
configurations that omit the interrupt line, preventing dtbs_check from
passing for those setups. Since the driver can operate in a polling-based
model for raw reads, it seems an interrupt might not be strictly required,
similar to the icm42607/p which was intentionally omitted from this block.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261002-b4-inv_icm42370p-v5-0-c65281b745c9@axis.com?part=1