Re: [PATCH 3/4] ARM: dts: aspeed: add Intel AVCRP BMC

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dts: 64MB memory leak due to unreferenced dynamically allocated video_memory
--

commit d3847f898b02cabadeb24ded4f04a71970cdd026
Author: Dawid Glazik <dawid.glazik@linux.intel.com>

ARM: dts: aspeed: add Intel AVCRP BMC
    
Add the initial AST2600 device tree for the Intel AVCRP BMC platform.

> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-intel-avcrp.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-intel-avcrp.dts
> new file mode 100644
> index 0000000000000..ba00916891724
> --- /dev/null
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-intel-avcrp.dts

[ ... ]

> +	reserved-memory {
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		ranges;
> +
> +		video_engine_memory: jpegbuffer {
> +			size = <0x02000000>; /* 32M */
> +			alignment = <0x01000000>;
> +			compatible = "shared-dma-pool";
> +			reusable;
> +		};
> +
> +		video_memory: video {
> +			size = <0x04000000>;
> +			alignment = <0x01000000>;
> +			compatible = "shared-dma-pool";
> +			no-map;
> +		};
> +	};

[Severity: Medium]
Does this code leak 64MB of system memory? The video_memory node is defined
with size = <0x04000000> and no-map, which dynamically allocates 64MB of RAM
and removes it from the linear mapping.

However, this node is never referenced by any device via a memory-region
property (unlike video_engine_memory which is correctly referenced by &video).

Since it is unreferenced and dynamically allocated without a node_fixup to
write the reg property, no driver can discover or utilize this memory, and
it is permanently removed from the system.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1790344811.git.dawid.glazik@linux.intel.com?part=3