Re: [PATCH v3 3/4] clk: qcom: Add lpass audio clock controller driver for Glymur

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] kconfig: inconsistent SC_ prefix and missing select CLK_GLYMUR_GCC
--

commit 4d46e5258e028c341d462d1519e907620d08c409
Author: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>

clk: qcom: Add lpass audio clock controller driver for Glymur

Add support for the lpass audio clock controller found on Glymur based
devices. This would allow lpass peripheral loader drivers to control the
clocks and bring the subsystems out of reset.

> diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig
> index 27d0ab24d50a4..89e6a636e4973 100644
> --- a/drivers/clk/qcom/Kconfig
> +++ b/drivers/clk/qcom/Kconfig
> @@ -1274,6 +1274,17 @@ config SC_LPASSCC_8280XP
>  	  Say Y if you want to use the LPASS branch clocks of the LPASS clock
>  	  controller to reset the LPASS subsystem.
>  
> +config SC_LPASSCC_GLYMUR
> +	tristate "GLYMUR Low Power Audio Subsystem (LPASS) Clock Controller"
> +	depends on ARM64 || COMPILE_TEST

[Severity: Medium]
Should this symbol use the CLK_GLYMUR_ prefix instead of SC_ to ensure
consistency with other Glymur configurations?

Also, does this configuration need a select statement for CLK_GLYMUR_GCC?
Building the kernel with SC_LPASSCC_GLYMUR enabled while CLK_GLYMUR_GCC is
disabled can lead to the driver being built without the required global clock
controller infrastructure, potentially causing probe failures at runtime.

> +	default m if ARCH_QCOM
> +	help
> +	  Support for the LPASS clock controller on Glymur devices.
> +	  Say Y if you want to use the LPASS branch clocks of the LPASS clock
> +	  controller to reset the LPASS subsystem.  Required for the LPASS
> +	  audio macros and the SoundWire compute-mode controller to leave
> +	  reset on Glymur.
> +

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261002194436.1275056-1-srinivas.kandagatla@oss.qualcomm.com?part=3