Re: [PATCH v2 2/2] riscv: dts: sophgo: cv180x: Fix internal ephy node name

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dts: mismatch between commit message and actual node rename
--

commit ff7773f0965119de993db57ef5ec58df5146e727
Author: Chen-Yu Yeh <chenyou910331@gmail.com>

riscv: dts: sophgo: cv180x: Fix internal ephy node name

This commit updates the internal EPHY node name in cv180x.dtsi to match its
reg property. It aims to rename the node to follow the common ethernet PHY
naming convention.

> diff --git a/arch/riscv/boot/dts/sophgo/cv180x.dtsi b/arch/riscv/boot/dts/sophgo/cv180x.dtsi
> index ec3bf305274ae..cf672cc6b9351 100644
> --- a/arch/riscv/boot/dts/sophgo/cv180x.dtsi
> +++ b/arch/riscv/boot/dts/sophgo/cv180x.dtsi
> @@ -71,7 +71,7 @@ internal_mdio: mdio@0 {
>  				#size-cells = <0>;
>  				reg = <0>;
>  
> -				internal_ephy: phy@0 {
> +				internal_ephy: phy@1 {

[Severity: Medium]
Does this node rename mismatch the commit message and skip generic Ethernet
PHY schema validation?

The commit message states "Rename the node to ethernet-phy@1", but the code
only changes the unit address from "phy@0" to "phy@1", omitting the
"ethernet-" prefix. This mismatch causes the node to silently skip the
standard validation in ethernet-phy.yaml, which expects the node name to
match the pattern ^ethernet-phy(@[a-f0-9]+)?$.

>  					compatible = "ethernet-phy-ieee802.3-c22";
>  					reg = <1>;
>  				};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261003084627.353899-1-chenyou910331@gmail.com?part=2