Re: [PATCH RFC 1/3] dt-bindings: net: wireless: qcom,ath12k: add disable-rfkill

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: missing vendor prefix for disable-rfkill property
--

commit d593ac46878299b5684cd1382162cee9211044a1
Author: Franz <franzelfranzel@gmail.com>

dt-bindings: net: wireless: qcom,ath12k: add disable-rfkill

This commit adds a disable-rfkill boolean property to the Qualcomm ath12k
device tree bindings. It allows DT-based platforms to indicate that the
hardware rfkill input is unusable and should not be enabled by the driver.

> diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath12k.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath12k.yaml
> index dc68dd59988fc..d56050e77a5b9 100644
> --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath12k.yaml
> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath12k.yaml
> @@ -27,6 +27,13 @@ properties:
>        If present, a board or platform specific string used to lookup
>        usecase-specific firmware files for the device.
>  
> +  disable-rfkill:

[Severity: Low]
Does this custom property need a vendor prefix?

According to standard device tree design principles, device-specific
properties must use a vendor prefix. Because this property is not defined in
any generic wireless or core schema and is introduced specifically for
ath12k, should it be named with a vendor prefix, such as
qcom,disable-rfkill?

> +    type: boolean
> +    description:
> +      The device's hardware rfkill input is not usable on this board (for
> +      example, it is not wired and reads as "radio off"). The driver must
> +      not enable hardware rfkill handling.
> +

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261003091509.4822-1-franzelfranzel@gmail.com?part=1