From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm2-f13.google.com (mail-wm2-f13.google.com [74.125.225.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CEE2745199F for ; Sat, 3 Oct 2026 20:22:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.141 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791058927; cv=none; b=joHFtS0syNy0CDyPffoLpay/skSxStN9Ybdxku4f+Br2bM3ZZnS1NqkG2yX7kCA0TwMHTxFuV5NNZZm81ZFuhiZNRBULdXUyFxk3lt2FtEUmdSLh2eTGfTb7obFXyOdX1LQjlaZXuGUBsiz5zZQ6jT+2n/b2i+ivQVf+HXJN8d8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791058927; c=relaxed/simple; bh=vHlNApf1n0eU2OktVinpI4zv/MZunnjQ95s6jli1xzM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=j4DIxMBCqYX2NXf3Fqh0ipSAJ0l8F0c9J9wwX5xxo66qF5sOxniRemeXOqCUpaiFUwi33P+cKOTbvJSj6kT75AsVANBEUJy81f7jJ1WOLnLJMLP9fILEm1xVAOZA3GqMBJWC8PDKt2VCXoKVUBdzbRXHu6XZaCK33mSOArLWN6M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=E9CpxOpQ; arc=none smtp.client-ip=74.125.225.141 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="E9CpxOpQ" Received: by mail-wm2-f13.google.com with SMTP id 5b1f17b1804b1-4a11603310fso7263545e9.1 for ; Sat, 03 Oct 2026 13:22:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791058919; x=1791663719; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=jdTRy1oUzdTMPfJnHsa0F48c4vY6O6GHObHAbcTX0Q8=; b=E9CpxOpQvqdDyv5L3mchbAdOH00kUUYB8lcQJjG10gcp6tkpDTJacm0DgQWTRhLV0T tAwTjRZwqcREb4depS7jx7wRB8pupFAd5/eWZlx+d1KO2N1OzFJk7d07pG36kIMRg3cw MWFmEjYqSCc343DZ+IlEeGeifBDF7hKrk+hKO01txOXbMwydszp98Fcm052sbI6I4WXd 5UPZpXJRrm3S+XbzfdIGMSBuneyVb+5VXYi3rF+RBqdaRkJoVyEGifmF2Z67N/hq0UbE 33V4fUhOJlJAcxcL6qVPi9UUPtZECO/DS03hKW0gfQQrtCzcNfiHnOGjqJNLq5Hy6t5x KvHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791058919; x=1791663719; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=jdTRy1oUzdTMPfJnHsa0F48c4vY6O6GHObHAbcTX0Q8=; b=pdFpP9dD71etPrcbt5Fxhoo0yEI3fC0AEIoP3/7PZOaX1nT6Vn3vpKdkhXmXDwHTK6 rk2DAlm5ktXMsaqVNLuxe8uWIrBeyXng4PAqhe2lOjUS3jdo0Cp+g2PzVmCfkZjAqAiQ 87nArrewq/yDYGUZKafZwA8/jRa3y8l9Er428RS+iM7otz4VpibDJ8nTICAyaZbNuL4+ dIoALDG4oze+zhjztpnFYnE25BcN5aaJAnLrIr0l1llirf5SckVIRhC83fhaqwG17Amc ZU3iOrAQzrqgMxCJtAU1MluROwdXvywyotSK/atsVllUA6wWy/+Je2x5ffK2nC01u9SJ /cwg== X-Forwarded-Encrypted: i=1; AKwUvBxsHr5J5bCDMyhECbFVSIWee262or+N+3tvUdEKpv1R6W6oP9a8JpL6HqO+3W9lz/AKiLDSWvTFSnIc@vger.kernel.org X-Gm-Message-State: AFuF++mVMS4FEd/GOfOCdkDVpAwYQ2GB91RMcQ8yX9dXVgStGzyTZoxu qY0qfNcz8mnLz3VrG3S6NlNHl3r8RSfeLImxSHFwbSztDXgAtBhadrA2 X-Gm-Gg: AYBFou3tqVw6+HQTJupTt9lfEQ/GXG93FAIP70vLWVVoOm3RS1CFAHuUZ3QL+YnYZmL 3kJi2+5JTg+l3hmXUfhBivq0MqVJjcDdLrcsd2KVpe1joibJP6cJ10sXayz06k72GsHT1nMA1C5 MgXYI/qJYAHYE7uygBbNVlut5ABEurIK2U0z8E1PVuIWO27sxpY9ifdUGjxdPd0dnbDtpu9Ip2m WIHty3OMcJC9v+JTjbFox4jEFcX4M3S6xt9kok/NpbodwX0wTYLu76ftHz7B6Sjl1mV1utEiiQ/ gqN1+PQdszKS1oc6UdfKiakJzQPRa2rGr7T0xqhMw7OKtvSO2fdxmaqQJs+zd9V4jqjhzVnfKa8 eN5ZBsFdMX4LId/1MaEwhbayR2YzDWvaswXO8IznxK5qEwlZSggAVxkj1tMVCAs7pYc0oOKwf1R 9PQ28A54ayvx5g0fu1+Bz2NXY2kc6ZsGsD/aUBgWWhLCYniunhTe+CasTANyK1UyN3uaNe8KXMy f6NIg== X-Received: by 2002:a05:600c:608d:b0:49f:e8bf:8f9b with SMTP id 5b1f17b1804b1-4a02750fa51mr115371465e9.4.1791058918814; Sat, 03 Oct 2026 13:21:58 -0700 (PDT) Received: from localhost.localdomain ([94.252.75.11]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-48b380facfesm15083316f8f.23.2026.10.03.13.21.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 03 Oct 2026 13:21:58 -0700 (PDT) From: Oleg Keri To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , "Bryan O'Donoghue" , Guenter Roeck , Bjorn Andersson , Konrad Dybcio , Abel Vesa Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-hwmon@vger.kernel.org, Konrad Dybcio , Abel Vesa Subject: [PATCH v5 3/3] arm64: dts: qcom: glymur-lenovo-yoga-slim7x: add the embedded controller Date: Sat, 3 Oct 2026 22:21:43 +0200 Message-ID: <20261003202143.4697-4-okerixx@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20261003202143.4697-1-okerixx@gmail.com> References: <20261003202143.4697-1-okerixx@gmail.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Describe the Compal embedded controller on I2C at address 0x70. It provides the board thermistors and the CPU fan speed, and drives the keyboard backlight. Its interrupt line is TLMM gpio66, falling edge, for which the file already carries a pin state. That state leaves the pin without a bias. gpio66 has no external pull and floats when the EC is not driving it, which shows up as a steady stream of spurious edges; the vendor ACPI tables describe the same pin as GpioInt(Edge, ActiveLow, Exclusive, PullUp). Enable the pull-up. Signed-off-by: Oleg Keri Reviewed-by: Konrad Dybcio Reviewed-by: Abel Vesa --- .../boot/dts/qcom/glymur-lenovo-yoga-slim7x.dts | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/glymur-lenovo-yoga-slim7x.dts b/arch/arm64/boot/dts/qcom/glymur-lenovo-yoga-slim7x.dts index 769f195c99d9..bc840fd8e458 100644 --- a/arch/arm64/boot/dts/qcom/glymur-lenovo-yoga-slim7x.dts +++ b/arch/arm64/boot/dts/qcom/glymur-lenovo-yoga-slim7x.dts @@ -659,7 +659,15 @@ &i2c9 { status = "okay"; - /* EC @ 0x70, irq = TLMM 66 */ + embedded-controller@70 { + compatible = "lenovo,yoga-slim7x-gen11-ec"; + reg = <0x70>; + + interrupts-extended = <&tlmm 66 IRQ_TYPE_EDGE_FALLING>; + + pinctrl-0 = <&ec_int_n_default>; + pinctrl-names = "default"; + }; }; &lpass_vamacro { @@ -990,7 +998,7 @@ reset-n-pins { ec_int_n_default: ec-int-n-state { pins = "gpio66"; function = "gpio"; - bias-disable; + bias-pull-up; }; kybd_default: kybd-default-state { -- 2.55.0