Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Nora Schiffer" <nora.schiffer@ew.tq-group.com>
Cc: lee@kernel.org, robh@kernel.org, conor+dt@kernel.org,
	linux-leds@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v5 09/11] leds: pca995x: Add sysfs files for error reporting
Date: Mon, 05 Oct 2026 14:26:55 +0000	[thread overview]
Message-ID: <20261005142655.C46541F000FF@smtp.kernel.org> (raw)
In-Reply-To: <5ec0d621cc430d730e51845d4aafb1c2be166fbc.1791207391.git.nora.schiffer@ew.tq-group.com>

> The PCA9955B/PCA9956B have builtin failure detection. Provide sysfs files
> for individual LED status (reporting "okay", "short-circuit" or
> "open-circuit") as well as a global "has_errors" flag. has_errors is
> sticky and must be cleared by writing "clear" to the sysfs file.
> 
> Failure detection on the PCA9952/PCA9955 (without "B") works differently
> and is currently unsupported.
> 
> Signed-off-by: Nora Schiffer <nora.schiffer@ew.tq-group.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1791207391.git.nora.schiffer@ew.tq-group.com?part=9


  reply	other threads:[~2026-10-05 14:26 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-05 13:53 [PATCH v5 00/11] leds: pca995x: Minor fixes; reset, output-gain, error reporting and group brightness support Nora Schiffer
2026-10-05 13:53 ` [PATCH v5 01/11] dt-bindings: leds: pca995x: Describe reset-gpios property Nora Schiffer
2026-10-05 14:21   ` sashiko-bot
2026-10-05 13:53 ` [PATCH v5 02/11] dt-bindings: leds: pca995x: Describe nxp,output-gain property Nora Schiffer
2026-10-05 14:23   ` sashiko-bot
2026-10-05 13:53 ` [PATCH v5 03/11] leds: pca995x: Fix maximum LED index for 16-channel variants Nora Schiffer
2026-10-05 14:27   ` sashiko-bot
2026-10-05 13:53 ` [PATCH v5 04/11] leds: pca995x: Fix fwnode handle leaks in error paths Nora Schiffer
2026-10-05 14:28   ` sashiko-bot
2026-10-05 13:53 ` [PATCH v5 05/11] leds: pca995x: Write global registers before creating LED devices Nora Schiffer
2026-10-05 14:24   ` sashiko-bot
2026-10-05 13:53 ` [PATCH v5 06/11] leds: pca995x: Add support for reset GPIO Nora Schiffer
2026-10-05 14:25   ` sashiko-bot
2026-10-05 13:53 ` [PATCH v5 07/11] leds: pca995x: Make output gain configurable Nora Schiffer
2026-10-05 14:25   ` sashiko-bot
2026-10-05 13:53 ` [PATCH v5 08/11] leds: pca995x: Initialize MODE2 register on probe Nora Schiffer
2026-10-05 14:25   ` sashiko-bot
2026-10-05 13:53 ` [PATCH v5 09/11] leds: pca995x: Add sysfs files for error reporting Nora Schiffer
2026-10-05 14:26   ` sashiko-bot [this message]
2026-10-05 13:53 ` [PATCH v5 10/11] leds: pca995x: Do not use full on LED mode Nora Schiffer
2026-10-05 14:26   ` sashiko-bot
2026-10-05 13:53 ` [PATCH v5 11/11] leds: pca995x: Add support for group brightness control Nora Schiffer
2026-10-05 14:27   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261005142655.C46541F000FF@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=lee@kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=nora.schiffer@ew.tq-group.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox