Re: [PATCH 3/3] arm64: dts: qcom: monaco-evk: Add suspend-only power collapse state

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dts: qcom: invalid AI hallucinated latencies in system_suspend
--

commit 31318bb17563026be6b93cecd9358caf654ab7fb
Author: Maulik Shah <maulik.shah@oss.qualcomm.com>

arm64: dts: qcom: monaco-evk: Add suspend-only power collapse state

This patch adds a deepest system power collapse state reserved for system-wide
suspend (s2idle) on the Monaco EVK board, requiring coordinated power-down of
CPUSS and the Safety Island (SAIL) subsystem.

> diff --git a/arch/arm64/boot/dts/qcom/monaco-evk.dts b/arch/arm64/boot/dts/qcom/monaco-evk.dts
> index 539c9c80a808d..b2978be6823dc 100644
> --- a/arch/arm64/boot/dts/qcom/monaco-evk.dts
> +++ b/arch/arm64/boot/dts/qcom/monaco-evk.dts

[ ... ]

> @@ -80,6 +80,19 @@ m2_e_uart_ep: endpoint@0 {
>  		};
>  	};
>  
> +	cpus {
> +		domain-idle-states {
> +			system_suspend: domain-suspend {
> +				compatible = "domain-idle-state";
> +				arm,psci-suspend-param = <0x4200C344>;
> +				entry-latency-us = <706562>;
> +				exit-latency-us = <706562>;
> +				min-residency-us = <709987>;

[Severity: Medium]
Are these latency values physically accurate for the hardware?

The min-residency-us value of 709,987 us is strictly less than the combined
entry and exit latencies of 1,413,124 us (706,562 + 706,562). This appears
invalid, as a state cannot typically yield power benefits before the hardware
has finished transitioning into and out of it. 

Additionally, 706 milliseconds seems unusually high for a transition time on
an EVK board. Since the commit message mentions this was AI-assisted, could 
these numbers be hallucinated placeholders that need to be replaced with 
actual measured hardware values?

> +				system-state;
> +			};
> +		};
> +	};
> +

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261005-s2idle_state-v1-0-3c402c66f388@oss.qualcomm.com?part=3